Skip to content
This repository was archived by the owner on Oct 15, 2024. It is now read-only.

Conversation

@msfjarvis
Copy link
Member

📢 Type of change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates

📜 Description

  • Fixes instrumentation test job name
  • Cleans up and extracts the JS used for checking changed files
  • Adds basic compile checking for both build types
  • Fixes a lingering Timber use missed in Replace Timber with logcat #1509

💡 Motivation and Context

Our builds do not check the nonFree source set which allowed a compile error to slip through to develop and break snapshot deployment.

💚 How did you test it?

Verified nonFreeDebug builds correctly and the new JS code executes correctly in a REPL

📝 Checklist

  • I formatted the code ./gradlew spotlessApply
  • I reviewed submitted code
  • I added a CHANGELOG entry if applicable

🔮 Next steps

📸 Screenshots / GIFs

@msfjarvis msfjarvis requested a review from a team as a code owner October 3, 2021 11:46
@msfjarvis msfjarvis added this to the v2.0.0 milestone Oct 3, 2021
@msfjarvis msfjarvis added A-CI-CD Area: Continuous Integration/Deployment C-bug Category: This is a bug C-technical-debt Category: This makes the code harder to read and modify, but has no impact on end users E-easy Effort: Should be easy to implement and would make a good first PR P-high Priority: high, must be resolved before next major release labels Oct 3, 2021
@msfjarvis msfjarvis force-pushed the hs/2021-10-03/refactor-ci branch from 7aa5373 to 23ded0f Compare October 3, 2021 11:52
This ensures code in the nonFree source set is also correctly tested
@msfjarvis msfjarvis force-pushed the hs/2021-10-03/refactor-ci branch 2 times, most recently from 1464d7e to 3006353 Compare October 3, 2021 12:06
@msfjarvis msfjarvis marked this pull request as draft October 3, 2021 12:06
@msfjarvis msfjarvis force-pushed the hs/2021-10-03/refactor-ci branch 3 times, most recently from df4b3e7 to c7a788a Compare October 3, 2021 12:14
@msfjarvis msfjarvis force-pushed the hs/2021-10-03/refactor-ci branch from c7a788a to 798639e Compare October 3, 2021 12:26
@msfjarvis msfjarvis marked this pull request as ready for review October 3, 2021 12:26
@msfjarvis msfjarvis enabled auto-merge (squash) October 3, 2021 12:34
@msfjarvis msfjarvis merged commit 9958697 into develop Oct 3, 2021
@msfjarvis msfjarvis deleted the hs/2021-10-03/refactor-ci branch October 3, 2021 12:39
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

A-CI-CD Area: Continuous Integration/Deployment C-bug Category: This is a bug C-technical-debt Category: This makes the code harder to read and modify, but has no impact on end users E-easy Effort: Should be easy to implement and would make a good first PR P-high Priority: high, must be resolved before next major release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants