Skip to content
This repository was archived by the owner on Oct 15, 2024. It is now read-only.

Conversation

@pickfire
Copy link
Contributor

📢 Type of change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates

📜 Description

Currently I do use mail: rather than email: locally, I think it would be good to have it as well.

💡 Motivation and Context

I used mail rather than email because it looks nice since both mail and user have 4 characters and it aligns together.

💚 How did you test it?

No

📝 Checklist

  • I formatted the code ./gradlew spotlessApply
  • I reviewed submitted code
  • I added a CHANGELOG entry if applicable

🔮 Next steps

📸 Screenshots / GIFs

@pickfire pickfire requested a review from a team as a code owner December 29, 2021 09:42
Copy link
Member

@fmeum fmeum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks useful.

Copy link
Member

@msfjarvis msfjarvis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs an addition to testGetUsername in format-common/src/test/kotlin/dev/msfjarvis/aps/data/passfile/PasswordEntryTest.kt

@msfjarvis msfjarvis added A-passfile Area: Password file format C-feature Category: This is a feature request S-waiting-on-author Status: This PR is incomplete or needs to address review comments labels Dec 29, 2021
@msfjarvis msfjarvis added this to the v2.0.0 milestone Dec 29, 2021
@msfjarvis msfjarvis added S-waiting-on-review Status: This pull request has been implemented and needs to be reviewed and removed S-waiting-on-author Status: This PR is incomplete or needs to address review comments labels Dec 29, 2021
@msfjarvis msfjarvis self-assigned this Dec 29, 2021
@msfjarvis msfjarvis enabled auto-merge (squash) December 29, 2021 09:51
@msfjarvis msfjarvis removed the S-waiting-on-review Status: This pull request has been implemented and needs to be reviewed label Dec 29, 2021
@msfjarvis msfjarvis merged commit 8b5be3f into android-password-store:develop Dec 29, 2021
@pickfire pickfire deleted the patch-1 branch December 29, 2021 14:20
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

A-passfile Area: Password file format C-feature Category: This is a feature request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants