Skip to content
This repository was archived by the owner on Oct 15, 2024. It is now read-only.

Conversation

@fmeum
Copy link
Member

@fmeum fmeum commented Jun 3, 2020

📢 Type of change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring

📜 Description

Improve the behavior of the Git password/passphrase dialog in two ways:

  • When the same InteractivePasswordFinder is used for authentication twice, e.g., for the push following a pull in a sync operation, the second prompt should not count as a retry. Otherwise, the remembered passphrase would always be cleared.
  • Since we don't want to ask the user for their password/passphrase twice for a single sync operation, the password is now cached for the entire GitOperation and cleared in GitAsyncTasks onPostExecute.

💡 Motivation and Context

Fixes #828.

💚 How did you test it?

I ran a few sync and push operations.

📝 Checklist

  • I formatted the code with the IDE's reformat action (Ctrl + Shift + L/Cmd + Shift + L)
  • I reviewed submitted code

🔮 Next steps

📸 Screenshots / GIFs

@fmeum fmeum merged commit 4172c70 into android-password-store:master Jun 3, 2020
@fmeum fmeum deleted the fhenneke_ssh_retry_fix branch June 3, 2020 08:08
fmeum added a commit that referenced this pull request Aug 12, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] Alert dialog is shown 2 times when synchronizing repository and doesn't save passphrase

2 participants