This repository was archived by the owner on Oct 15, 2024. It is now read-only.
Improve Git password/passphrase dialog behavior #829
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📢 Type of change
📜 Description
Improve the behavior of the Git password/passphrase dialog in two ways:
InteractivePasswordFinderis used for authentication twice, e.g., for the push following a pull in a sync operation, the second prompt should not count as a retry. Otherwise, the remembered passphrase would always be cleared.GitOperationand cleared inGitAsyncTasksonPostExecute.💡 Motivation and Context
Fixes #828.
💚 How did you test it?
I ran a few sync and push operations.
📝 Checklist
🔮 Next steps
📸 Screenshots / GIFs