[BUG] Alert dialog is shown 2 times when synchronizing repository and doesn't save passphrase

[Dioxo]

Describe the bug
If not checked "remember password"
The alert dialog when synchronizing the repository is shown twice, the second time it shows as "wrong passphrase".

If checked "remember password"
The alert dialog is shown once, but password is not saved.

It only happens with this option, if I try with pull or push, it doesn't display many times and saves the password (but i don't see any confirmation when adding wrong or correct password, not sure what this prompt does...)

To Reproduce
Steps to reproduce the behavior:

1. Clear saved passphrase for local ssh key (if there's any)
2. Try to sync

Expected behavior
The alert dialog only shows once and the passphrase is saved if checked box.

Device information (please complete the following information):

• Device: Redmi Note 8
• OS: 9.0
• App version : Recently pulled from repo.

potential cause
I tried to solve this problem but I couldn't because this error is generated since synchronization makes a call to pull and another to push.
It's each call that generates the alert dialog. It's normal that the error "wrong passphrase" comes up because the application tries to make 2 consecutive calls and takes them as if it was a password error, but in reality the first one is a call to pull and the next one is to push.

And because the second time the application considers that it was a "password error", it deletes the saved password.

I add captures of the application stack to justify why I think it's the push and pull calls that call this method of displaying the alert dialog. At the bottom left you can see that the first time is called by a pull command and the second time is the push command.

The firs time that the prompt is shown.

The second time.

[fmeum]

@msfjarvis I'll see whether I can fix this independent of the answer to the following question, but do we know why JGit chooses to authenticate twice for a git pull followed by a git push? If we could resolve that, we would have both solved this issue and saved a roundtrip to the server.

[msfjarvis]

@msfjarvis I'll see whether I can fix this independent of the answer to the following question, but do we know why JGit chooses to authenticate twice for a git pull followed by a git push? If we could resolve that, we would have both solved this issue and saved a roundtrip to the server.

It's running multiple commands separately [reference]. Not sure if this can be avoided, will investigate.

[fmeum]

@Dioxo Could you check whether #829 fixes the issue for you? It should both fix the retry issue and remember the password for the duration of the entire sync operation.

@msfjarvis Are we okay with remembering the password for that long? We did previously and are now taking better care to clear it, but I still want to get your ok.

[msfjarvis]

@msfjarvis Are we okay with remembering the password for that long? We did previously and are now taking better care to clear it, but I still want to get your ok.

I think it's a perfectly reasonable duration, no issues with it.

[Dioxo]

@FabianHenneke it works almost perfect with the fix that you did, the only problem is that the sync contains 2 operations (pull and push), so if i cancel the alert dialog when sync, it will cancel for the pull call, but it will show again the alert dialog for the push call.

I would like to ask you what's the idea of this Alert Dialog? even if i type anything or cancel it, it will pull or push no matter what.

[fmeum]

@FabianHenneke it works almost perfect with the fix that you did, the only problem is that the sync contains 2 operations (pull and push), so if i cancel the alert dialog when sync, it will cancel for the pull call, but it will show again the alert dialog for the push call.

I would like to call that intended behavior for the purpose of that dialog. It's more of a question whether the sync operation should or should not run the push after the pull fails. @msfjarvis What do you think?

I would like to ask you what's the idea of this Alert Dialog? even if i type anything or cancel it, it will pull or push no matter what.

Could you provide me with steps to reproduce that? When I cancel the dialog, I get an error about SSHJ failing to read my key file - which makes sense as it can't read the private key without its passphrase.

[Dioxo]

I would like to call that intended behavior for the purpose of that dialog. It's more of a question whether the sync operation should or should not run the push after the pull fails. @msfjarvis What do you think?

For me, the sync is a atomic operation, even if it has to do a pull and after the push, if one of them fails, it would be usefull to have a error message.

Could you provide me with steps to reproduce that? When I cancel the dialog, I get an error about SSHJ failing to read my key file - which makes sense as it can't read the private key without its passphrase.

I didn't do something different, the first time when cloning the repo i dont check "remember passphrase", and when i manually do a pull or push, if i cancel the alert dialog, it just do the action ignoring the fact that i canceled it.

[Dioxo]

Or even if i write anything and press "OK", it continues to pull and push. That's why i ask about the funcionality about this because the operations work no matter what I write or do in the alert dialog.