This repository was archived by the owner on Oct 15, 2024. It is now read-only.
Don't show an error if password prompt is cancelled #833
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
This works really well! Cool. The error when cancelling prompt is gone. |
msfjarvis
approved these changes
Jun 4, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📢 Type of change
📜 Description
Don't show an error if the user chose to cancel a password or passphrase prompt during SSH authentication.
@msfjarvis Currently, the keyboard flickers when the calling activity is finished. Do you know what could cause this?
💡 Motivation and Context
Fixes #828.
💚 How did you test it?
I verified that the retry logic still works correctly, but no error is shown when I tap 'Cancel'.
📝 Checklist
🔮 Next steps
📸 Screenshots / GIFs