This repository was archived by the owner on Oct 15, 2024. It is now read-only.
Improve bulk deletion and password move flow #855
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
8 tasks
Member
Author
|
Once reviewed I'd prefer if we submitted via rebase since the commits make much more sense separately for anyone traversing through past history to find why things were done the way they were. |
fmeum
reviewed
Jun 15, 2020
Co-authored-by: Fabian Henneke <FabianHenneke@users.noreply.github.com>
Co-authored-by: Fabian Henneke <FabianHenneke@users.noreply.github.com>
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
fmeum
reviewed
Jun 16, 2020
fmeum
approved these changes
Jun 17, 2020
msfjarvis
added a commit
to Dioxo/Android-Password-Store
that referenced
this pull request
Jun 17, 2020
* master: Improve bulk deletion and password move flow (android-password-store#855) Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📢 Type of change
📜 Description
Replaces the recursive, Stack oriented password deletion code to just be linear. Employed a couple
of tricks to ensure better UX via accurate file counts and better commit messages.
💡 Motivation and Context
The ability to batch delete without spending a century tapping OK on dialogs was requested in #853
Everything else just came from my hate for
startActivityForResult.💚 How did you test it?
Deleted passwords, moved passwords, enjoyed every bit of it.
📝 Checklist
🔮 Next steps
Death to
startActivityForResult!