This repository was archived by the owner on Oct 15, 2024. It is now read-only.
Use a more common SSH version string #944
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msfjarvis
approved these changes
Jul 20, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📢 Type of change
📜 Description
We are currently using an empty SSH version string, which might cause compatibility issues. SSHJ's default leaks the fact that we are using SSHJ version 0.29.0, which is unnecessary.
In order to maximize compatibility with servers that might be basing decisions on our version string, with this commit we are now using the one of Ubuntu 20.04.
💡 Motivation and Context
💚 How did you test it?
📝 Checklist
🔮 Next steps
📸 Screenshots / GIFs