Skip to content
This repository was archived by the owner on Oct 15, 2024. It is now read-only.

Add pt-BR translations and cleanup resources #947

Merged
merged 5 commits into from
Jul 22, 2020
Merged

Add pt-BR translations and cleanup resources #947

merged 5 commits into from
Jul 22, 2020

Conversation

@msfjarvis
Copy link
Member

@msfjarvis msfjarvis commented Jul 21, 2020 •
edited
Loading

📢 Type of change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates

📜 Description

Import Portugese, Brazilian translations from Crowdin, and cleanup unused resources.

💡 Motivation and Context

This is the first batch of completed translations, and strings need to be trimmed down to ensure that only the ones being used are part of the file and translators don't end up doing extra work.

💚 How did you test it?

📝 Checklist

  • I formatted the code with the IDE's reformat action (Ctrl + Shift + L/Cmd + Shift + L)
  • I reviewed submitted code
  • I added a CHANGELOG entry if applicable

🔮 Next steps

📸 Screenshots / GIFs

@msfjarvis msfjarvis added this to the 1.10.0 milestone Jul 21, 2020
msfjarvis added 2 commits July 22, 2020 04:59
@msfjarvis
strings: add pt-BR translations
65b4e5f 
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
@msfjarvis
Update changelog
33da003 
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
@fmeum fmeum closed this Jul 22, 2020
@fmeum fmeum reopened this Jul 22, 2020
msfjarvis added 2 commits July 22, 2020 12:50
@msfjarvis
app: move nonFree specific layout to its source set
c13f6e0 
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
@msfjarvis
Remove unused resources
84096a7 
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
@msfjarvis msfjarvis changed the title strings: add pt-BR translations Add pt-BR translations and cleanup resources Jul 22, 2020
@msfjarvis
Move nonFree string resource to its source set
64e633c 
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
@msfjarvis
Copy link
Member Author

msfjarvis commented Jul 22, 2020

Studio marks resources only used under nonFree source set as unused and deletes them from main so I've moved them to app/src/nonFree.

@msfjarvis msfjarvis merged commit fb5f4e4 into android-password-store:develop Jul 22, 2020
@msfjarvis msfjarvis deleted the update-pt-BR branch July 22, 2020 08:07
msfjarvis added a commit that referenced this pull request Jul 22, 2020
@msfjarvis
Merge branch 'develop' into enhancement/autofill_custom_views
49cadb9 
* develop:
  github: create release as draft
  build: prepare next development version
  build: bump version
  Prepare release 1.10.0
  github: fix paths to binaries
  Add pt-BR translations and cleanup resources (#947)
  Use a more common SSH version string (#944)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@fmeum fmeum Awaiting requested review from fmeum

1 more reviewer

@Skrilltrax Skrilltrax Skrilltrax approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

1.10.0

Development

Successfully merging this pull request may close these issues.

3 participants

@msfjarvis @Skrilltrax @fmeum