This repository was archived by the owner on Oct 15, 2024. It is now read-only.
Fix OpenPgpApi extra type confusion #960
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msfjarvis
approved these changes
Jul 23, 2020
Member
msfjarvis
left a comment
msfjarvis
left a comment
There was a problem hiding this comment.
Allow me a moment while I tear my hair out at this idiocy.
msfjarvis
added a commit
that referenced
this pull request
Jul 26, 2020
* develop: (28 commits) Allow creating nested directories CHANGELOG: update Show parent path on all types github: upload test reports on failure build: update APK cruft exclusion list Properly handle files without passwords (#969) Expand OTP and PasswordEntry tests (#968) README: clarify build types (#966) build: prepare next development version build: bump version Prepare release 1.10.1 Add CHANGELOG entries for 1.10.1 (#961) Wire in fallback key selection flow (#958) Fix OpenPgpApi extra type confusion (#960) Fix a crash when parsing long key IDs (#959) Add CHANGELOG entries for 1.10.1 (#961) Wire in fallback key selection flow (#958) Fix OpenPgpApi extra type confusion (#960) Fix a crash when parsing long key IDs (#959) Allow Autofill on custom views with Autofill hints (#946) ... Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
msfjarvis
added a commit
that referenced
this pull request
Jul 27, 2020
* develop: Allow creating nested directories CHANGELOG: update Show parent path on all types github: upload test reports on failure build: update APK cruft exclusion list Properly handle files without passwords (#969) Expand OTP and PasswordEntry tests (#968) build: prepare next development version build: bump version Prepare release 1.10.1 Add CHANGELOG entries for 1.10.1 (#961) Wire in fallback key selection flow (#958) Fix OpenPgpApi extra type confusion (#960) Fix a crash when parsing long key IDs (#959)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📢 Type of change
📜 Description
Array<Long>andLongArrayare distinct types and the former is being passed to Java as aSerializablerather than aLong[]. With this change, encrypting to fingerprints and long key IDs of master keys now works.Note that providing the key ID of an encryption subkey does not seem to be supported by OpenKeychain.
💡 Motivation and Context
💚 How did you test it?
📝 Checklist
🔮 Next steps
📸 Screenshots / GIFs