Skip to content
This repository was archived by the owner on Oct 15, 2024. It is now read-only.

Migrate to Gradle Kotlin DSL #936

Merged
merged 13 commits into from
Jul 23, 2020
Merged

Migrate to Gradle Kotlin DSL #936

merged 13 commits into from
Jul 23, 2020

Conversation

@msfjarvis
Copy link
Member

@msfjarvis msfjarvis commented Jul 17, 2020 •
edited
Loading

📢 Type of change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates

📜 Description

Rewrites all build logic in Kotlin using Gradle's Kotlin DSL.

💡 Motivation and Context

I'm just really sick of Groovy.

💚 How did you test it?

Assemble tasks work properly, there's still some rough edges to sort out.

📝 Checklist

  • I formatted the code with the IDE's reformat action (Ctrl + Shift + L/Cmd + Shift + L)
  • I reviewed submitted code
  • I added a CHANGELOG entry if applicable

🔮 Next steps

📸 Screenshots / GIFs

msfjarvis added 2 commits July 18, 2020 03:25
@msfjarvis
build: switch to Gradle Kotlin DSL
fe0b9bb 
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
@msfjarvis
gradle: turn on FS watching
8e4c22c 
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
msfjarvis added 7 commits July 18, 2020 17:22
@msfjarvis
build: disable Lint on release builds
814a6d3 
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
@msfjarvis
Update AGP
79c12e8 
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
@msfjarvis
gradle: add build health plugin
ee42533 
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
@msfjarvis
build: mark AndroidX annotation as compileOnly
e5a296b 
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
@msfjarvis
build: remove unneeded explicit dependency
8dcf412 
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
@msfjarvis
Merge branch 'develop' into gradle-kotlin-dsl
7b38d2d 
* develop:
  Improve UI when launching with biometric lock (#940)
  Remove type images (#939)
  Always allow SSH key generation (#938)
@msfjarvis
Merge branch 'develop' into gradle-kotlin-dsl
c84d274 
* develop:
  github: create release as draft
  build: prepare next development version
  build: bump version
  Prepare release 1.10.0
  github: fix paths to binaries
  Add pt-BR translations and cleanup resources (#947)
  Use a more common SSH version string (#944)
  Add changelog entry for ed25519 support (#943)
  Fix Autofill result contract bug (#941)

Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
msfjarvis
msfjarvis commented Jul 23, 2020
View reviewed changes
msfjarvis added 3 commits July 23, 2020 13:07
@msfjarvis
build: bring back output renaming
011de94 
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
@msfjarvis
build: not a workaround
7630a68 
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
@msfjarvis
Merge branch 'develop' into gradle-kotlin-dsl
4de068f 
* develop:
  build: upgrade all dependencies (#953)

Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
@msfjarvis msfjarvis marked this pull request as ready for review July 23, 2020 07:45
@msfjarvis msfjarvis requested a review from Skrilltrax as a code owner July 23, 2020 07:45
@msfjarvis msfjarvis requested a review from fmeum July 23, 2020 07:45
@msfjarvis
build: little dash of fanciness
c30a433 
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
@msfjarvis msfjarvis merged commit 356a8cd into android-password-store:develop Jul 23, 2020
@msfjarvis msfjarvis deleted the gradle-kotlin-dsl branch July 23, 2020 09:09
msfjarvis added a commit that referenced this pull request Jul 23, 2020
@msfjarvis
Merge branch 'develop' into fix_key_id_parsing
3535ced 
* develop:
  Fix a crash when parsing long key IDs (#959)
  Allow Autofill on custom views with Autofill hints (#946)
  Migrate to Gradle Kotlin DSL (#936)
  build: upgrade all dependencies (#953)
  github: create release as draft
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@Skrilltrax Skrilltrax Awaiting requested review from Skrilltrax

1 more reviewer

@fmeum fmeum fmeum approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@msfjarvis @fmeum