[faq] improve messages hiding entry #82
Conversation
Deploying docs with
|
| Latest commit: |
f82cc6d
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://7b81c10b.docs-7wm.pages.dev |
| Branch Preview URL: | https://faq-improve-message-hiding-e.docs-7wm.pages.dev |
WalkthroughThe FAQ document in docs/faq/general.md has been updated by adding a new section titled "How to hide messages on the device?". This section explains the technical limitations imposed by Android since version 4.4 KitKat that prevent messages from being hidden or deleted within the SMS Gateway app. It also discusses why message hiding is not implemented to avoid potential spyware-like behavior, and it includes recommendations for maintaining device security. No changes were made to any public APIs or exported entities. Changes
Possibly related PRs
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms (1)
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (2)
docs/faq/general.md (2)
5-8: Clear Explanation of Technical Limitations
The new content succinctly explains that, due to Android’s technical constraints since 4.4 KitKat, SMS Gateway cannot modify or delete messages and will always display them in the default SMS app. For further clarity, you might consider rephrasing “delete/write messages” to “modify or delete messages,” though the current wording is understandable.
9-13: Minor Grammar Improvements in the Recommendation Tip
In the recommendation tip, consider adding the article “a” to enhance readability. For example, change:- - Set strong PIN code + - Set a strong PIN code - - Use dedicated Android device + - Use a dedicated Android deviceThese small adjustments improve clarity and consistency in the recommendations.
🧰 Tools
🪛 LanguageTool
[uncategorized] ~11-~11: You might be missing the article “a” here.
Context: ... physical access to the phone - Set strong PIN code - Use dedicated Android de...(AI_EN_LECTOR_MISSING_DETERMINER_A)
[uncategorized] ~12-~12: You might be missing the article “a” here.
Context: ...one - Set strong PIN code - Use dedicated Android device ## Can I send MMS messa...(AI_EN_LECTOR_MISSING_DETERMINER_A)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
docs/faq/general.md(1 hunks)
🧰 Additional context used
🪛 LanguageTool
docs/faq/general.md
[uncategorized] ~11-~11: You might be missing the article “a” here.
Context: ... physical access to the phone - Set strong PIN code - Use dedicated Android de...
(AI_EN_LECTOR_MISSING_DETERMINER_A)
[uncategorized] ~12-~12: You might be missing the article “a” here.
Context: ...one - Set strong PIN code - Use dedicated Android device ## Can I send MMS messa...
(AI_EN_LECTOR_MISSING_DETERMINER_A)
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: Cloudflare Pages
🔇 Additional comments (1)
docs/faq/general.md (1)
3-4: New FAQ Section Header Added
The section header “How to hide messages on the device? 🙈” is clear, engaging, and effectively introduces the subject.
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
docs/faq/general.md (1)
5-7: Clear Explanation of Technical Limitations and Design ChoiceThe text explains that due to Android limitations introduced in version 4.4 KitKat, SMS Gateway cannot delete messages and always displays them in the default SMS app. It also clarifies that while setting SMS Gateway as the default SMS app could technically allow message hiding, this approach is intentionally avoided to prevent any spyware-like behavior and to maintain transparency.
Suggestion: Consider adding a reference or a link to Android’s documentation or a relevant article for users interested in understanding these technical limitations in greater detail.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
docs/faq/general.md(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: Cloudflare Pages
🔇 Additional comments (2)
docs/faq/general.md (2)
3-3: Section Title ClarityThe new section title, "How to hide messages on the device? 🙈", is engaging and immediately communicates the topic. Consider whether specifying "SMS messages" might add even more clarity for users who might otherwise confuse it with other messaging types.
9-12: Well-Structured Security RecommendationsThe tip block provides clear and actionable security recommendations, such as restricting physical access, setting a strong PIN code, and using a dedicated Android device. This adds practical advice that complements the technical explanation nicely.
capcom6
force-pushed
the
faq/improve-message-hiding-entry
branch
from
7e89363 to
f82cc6d
Compare
Summary by CodeRabbit