[deps] upgrade go-infra-fx to skip logging health and metrics requests
#174
Conversation
WalkthroughUpdated a single dependency in Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 💡 Knowledge Base configuration:
You can enable these sources in your CodeRabbit configuration. ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
🔇 Additional comments (2)
✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (2)
go.mod (2)
12-12: Prefer a tagged release; otherwise annotate why the pseudo-version is required.If a tag (e.g., v0.2.5) containing the change is or becomes available, pin to it for reproducibility. If not, add a brief inline comment to explain the pin.
- github.com/capcom6/go-infra-fx v0.2.5-0.20250828235240-ca43b2b295cd + // contains: skip logging for health/metrics requests + github.com/capcom6/go-infra-fx v0.2.5-0.20250828235240-ca43b2b295cd
12-12: Ops note: logging dashboards/alerts may shift.Dropping health/metrics logs reduces noise but can affect log-based alerting or volume-based SLOs. Update queries/dashboards if they relied on those entries.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
⛔ Files ignored due to path filters (1)
go.sumis excluded by!**/*.sum
📒 Files selected for processing (1)
go.mod(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
- GitHub Check: Test
- GitHub Check: E2E
- GitHub Check: lint
- GitHub Check: Analyze (go)
🔇 Additional comments (1)
go.mod (1)
12-12: Verify the skip-logging pseudo-version and default health/metrics paths
- Confirm that the pseudo-version v0.2.5-0.20250828235240-ca43b2b295cd actually adds the “skip logging” filter and introduces no breaking changes to logging or HTTP middleware compared to v0.2.3.
- Ensure your application’s GET /health and GET /metrics endpoints are included in the new skip-logging list. If you expose different paths (e.g. /healthz, /_/health), update the filter or configuration accordingly.
- Double-check any changes in HTTP middleware options between v0.2.3 and this commit to avoid unintended side effects.
go.mod
Outdated
| github.com/ansrivas/fiberprometheus/v2 v2.6.1 | ||
| github.com/capcom6/go-helpers v0.3.0 | ||
| github.com/capcom6/go-infra-fx v0.2.3 | ||
| github.com/capcom6/go-infra-fx v0.2.5-0.20250828235240-ca43b2b295cd |
There was a problem hiding this comment.
💡 Verification agent
🧩 Analysis chain
Tidy and CI checks.
- Run go mod tidy and commit any go.sum changes.
- Ensure CI/tooling uses Go 1.23.x so the toolchain directive is honored.
🏁 Script executed:
#!/bin/bash
go version || true
git status --porcelain
# Expect: clean after 'go mod tidy'Length of output: 170
Use Go 1.23.x in CI
CI is currently running Go 1.24.1 (per go version); update your CI/tooling configuration to use Go 1.23.x so the module’s go directive is honored.
🤖 Prompt for AI Agents
In go.mod at line 12, the module declares a Go version that should be honored
but CI is using Go 1.24.1; update your CI/tooling to use Go 1.23.x to match the
module. Locate CI definitions (e.g., .github/workflows/* using actions/setup-go,
Dockerfiles, Makefile/toolchain scripts, or any CI image tags) and change the
configured Go version to a 1.23.x release (e.g., 1.23.7) or to a minor-range pin
that resolves to 1.23, then run the CI job locally or via the CI lint to confirm
builds use Go 1.23.x. Ensure any cached tool images are refreshed so the new
version is actually used.
capcom6
force-pushed
the
deps/upgrage-infra-to-skip-health-logging
branch
4 times, most recently
from
ae5a723 to
be8310e
Compare
|
Deployed... |
capcom6
force-pushed
the
deps/upgrage-infra-to-skip-health-logging
branch
from
be8310e to
e5fbe2f
Compare
Summary by CodeRabbit
Chores
Stability
No User-Facing Changes