-
Notifications
You must be signed in to change notification settings - Fork 217
Update dependencies #164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update dependencies #164
Conversation
Summary of ChangesHello @riggaroo, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on a significant dependency upgrade across the project, ensuring the application leverages the latest features, security patches, and performance enhancements from updated libraries. Concurrently, it addresses necessary API adaptations within the navigation and XR modules that arose from these dependency changes. Additionally, a new CI configuration is introduced to streamline the build and artifact collection for wear releases. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates various dependencies and adapts the code to the new library versions. The changes in MainNavigation.kt, libs.versions.toml, and the new Kokoro config file are correct and align with the goal of updating dependencies. In core/xr/src/main/java/com/android/developers/androidify/xr/SharedTransitions.kt, while adapting to API changes, some functions were changed from expression bodies to more verbose block bodies. I've suggested converting them back to expression bodies for conciseness, following Kotlin conventions. I also found and suggested fixing an issue with excessive blank lines in the same file.
core/xr/src/main/java/com/android/developers/androidify/xr/SharedTransitions.kt
Outdated
Show resolved
Hide resolved
core/xr/src/main/java/com/android/developers/androidify/xr/SharedTransitions.kt
Outdated
Show resolved
Hide resolved
core/xr/src/main/java/com/android/developers/androidify/xr/SharedTransitions.kt
Outdated
Show resolved
Hide resolved
core/xr/src/main/java/com/android/developers/androidify/xr/SharedTransitions.kt
Outdated
Show resolved
Hide resolved
…oidify into feature/app-updates
No description provided.