Skip to content

Update the placeholders for Compose Preview for HomeScreen.kt #84

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
riggaroo merged 11 commits into from
Jul 29, 2025
Merged

Update the placeholders for Compose Preview for HomeScreen.kt #84

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
ef96ffc
Preview Placeholders for HomeScreen.kt
pedrosax Jul 28, 2025
f6b61f4
Add placeholder images for HomeScreen.kt
pedrosax Jul 28, 2025
e82e465
Add files via upload
pedrosax Jul 28, 2025
c4cea48
Create dancing_droid_gif_placeholder.png
pedrosax Jul 28, 2025
3008f7c
Moving placeholder images to debug folder
pedrosax Jul 28, 2025
ef87135
Remove asset from main folder
pedrosax Jul 28, 2025
f2c3b51
remove promo_video_placeholder.png from main folder
pedrosax Jul 28, 2025
5f4324e
Create tmp file
pedrosax Jul 29, 2025
9e1e6bf
Moved pptimized PNG paceholder images
pedrosax Jul 29, 2025
7184a41
Delete feature/home/src/debug/res/drawable directory
pedrosax Jul 29, 2025
a7a7058
Delete feature/home/src/main/res/drawable-nodpi/tmp
pedrosax Jul 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
58 changes: 38 additions & 20 deletions feature/home/src/main/java/com/android/developers/androidify/home/HomeScreen.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,6 +75,7 @@ import androidx.compose.ui.graphics.Color
import androidx.compose.ui.graphics.graphicsLayer
import androidx.compose.ui.graphics.vector.ImageVector
import androidx.compose.ui.graphics.vector.rememberVectorPainter
import androidx.compose.ui.layout.ContentScale
import androidx.compose.ui.layout.onLayoutRectChanged
import androidx.compose.ui.layout.onVisibilityChanged
import androidx.compose.ui.platform.LocalContext
Expand Down Expand Up @@ -456,11 +457,19 @@ private fun DancingBot(
dancingBotLink: String?,
modifier: Modifier,
) {
AsyncImage(
model = dancingBotLink,
modifier = modifier,
contentDescription = null,
)
if (LocalInspectionMode.current) {
Image(
painter = painterResource(id = R.drawable.dancing_droid_gif_placeholder),
contentDescription = null,
modifier = modifier
)
Comment on lines +460 to +465
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Jul 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Consider extracting the Image composable into a separate function for better readability and maintainability. This would encapsulate the placeholder logic and make the DancingBot function cleaner.

@Composable
private fun DancingBotPlaceholder(modifier: Modifier = Modifier) {
    Image(
        painter = painterResource(id = R.drawable.dancing_droid_gif_placeholder),
        contentDescription = null,
        modifier = modifier
    )
}

// Usage in DancingBot:
if (LocalInspectionMode.current) {
    DancingBotPlaceholder(modifier = modifier)
}

} else {
AsyncImage(
model = dancingBotLink,
modifier = modifier,
contentDescription = null,
)
}
}

@Composable
Expand Down Expand Up @@ -520,23 +529,31 @@ private fun VideoPlayer(
videoLink: String?,
modifier: Modifier = Modifier,
) {
if (LocalInspectionMode.current) return // Layoutlib does not support ExoPlayer

val context = LocalContext.current
var player by remember { mutableStateOf<Player?>(null) }
LifecycleStartEffect(videoLink) {
if (videoLink != null) {
player = ExoPlayer.Builder(context).build().apply {
setMediaItem(MediaItem.fromUri(videoLink))
repeatMode = Player.REPEAT_MODE_ONE
prepare()
if (LocalInspectionMode.current) {
Image(
painter = painterResource(id = R.drawable.promo_video_placeholder),
contentDescription = null,
contentScale = ContentScale.Crop,
modifier = modifier,
)
return
Comment on lines +532 to +539
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Jul 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Consider extracting the Image composable into a separate function for better readability and maintainability. This would encapsulate the placeholder logic and make the VideoPlayer function cleaner.

@Composable
private fun VideoPlaceholder(modifier: Modifier = Modifier) {
    Image(
        painter = painterResource(id = R.drawable.promo_video_placeholder),
        contentDescription = null,
        contentScale = ContentScale.Crop,
        modifier = modifier,
    )
}

// Usage in VideoPlayer:
if (LocalInspectionMode.current) {
    VideoPlaceholder(modifier = modifier)
    return
}

} else {
val context = LocalContext.current
var player by remember { mutableStateOf<Player?>(null) }
LifecycleStartEffect(videoLink) {
if (videoLink != null) {
player = ExoPlayer.Builder(context).build().apply {
setMediaItem(MediaItem.fromUri(videoLink))
repeatMode = Player.REPEAT_MODE_ONE
prepare()
}
}
onStopOrDispose {
player?.release()
player = null
}
}
onStopOrDispose {
player?.release()
player = null
}
}


var videoFullyOnScreen by remember { mutableStateOf(false) }
val isWindowOccluded = LocalOcclusion.current
Expand Down Expand Up @@ -582,3 +599,4 @@ private fun VideoPlayer(
}
}
}
}
Binary file added feature/home/src/main/res/drawable-nodpi/dancing_droid_gif_placeholder.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added feature/home/src/main/res/drawable-nodpi/promo_video_placeholder.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.