Upgrade to Ink 1.1.0-alpha02#67
Open
maxmmitchell wants to merge 2 commits intomainfrom
Open
Conversation
… well to match protobufJavalite and support proto editions.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a comprehensive versioning system for the Ink protobuf definitions by implementing custom options for minimum message, field, and enum value versions. Key changes include the addition of an options.proto file, renaming and reserving various fields within BrushFamily and its components to improve API consistency, and updating the protobuf compiler to version 4.34.0. I have no feedback to provide.
maxmmitchell
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is mainly motivated by some of the newer brush customization features released in this version, as well as the versioning support for brush customization features. Brushes using those features will fail to load into Cahier without this update. Furthermore, in order for Brush Designer/Brush Graph to support editing/creating brushes with the newest features from Ink, Cahier needs the newest version of the library.
1.1.0-alpha02, the latest available version as of this PR.brush_family.protofrom Ink's C++ repo to get the most recent updates to the serialization format. OmittedLint.Ifcomments, as they include Ink-specific paths and aren't relevant for Cahier.options.protofrom Ink's C++ repo, as it is used by the newest changes tobrush_family.proto.protocas well to match the version used forprotobufJavalite. Needed to upgrade this to at least 4.27 to support proto editions (used byoptions.proto), and IIRC it's best practices to use the same version for these two (hence the jump to 4.34).In addition to supporting editing the new features (most of which we already had in the proto spec in Cahier, we just didn't have the Ink library to a version which could support decoding them), Brush Designer/Brush Graph may have to update a bit to accommodate other changes to the proto spec:
ExperimentalNaiveInput Model toPassthroughSpringInput Modelpaintat the top-level has gone from deprecated to removed from the spec entirely. I think we've been using paint preferences anyway, but just in case.TARGET_LUMINOSITYis nowTARGET_LUMINOSITY_OFFSET