Enable emoji highlighter entry point in brush graph#76
Merged
Conversation
Also alphabetize the custom brushes -- I messed this up on my prior PR and put them in out of order
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces an 'Emoji Highlighter' submenu to the brush graph menus, allowing users to select from various emoji-based brush templates, and reorders custom brush definitions for better organization. The review feedback highlights that the icon logic for submenus is non-standard; specifically, using ExpandMore for menus that open horizontally is misleading. It is recommended to use ChevronRight consistently to align with Material Design patterns for cascading menus.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Very similar to the code in brush designer's top bar which does similar handling. Uses chevron style icons instead of the character for the "arrow" indicating the submenu, in keeping with the aesthetics already present in brush graph's template menu/material design.
Some formatting changes came along too on save. Should be mostly whitespace there.
Also alphabetize the custom brushes -- I messed this up on my prior PR and put them in out of order. This fixes them back to being in order.