Use RepoViewHolder instead of ViewHolder #26
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avoid casting and use the RepoViewHolder class directly on the adapter class
vmadalin
approved these changes
Oct 19, 2019
florina-muntenescu
approved these changes
Jan 6, 2021
florina-muntenescu
pushed a commit
that referenced
this pull request
Feb 26, 2021
avoid casting and use the RepoViewHolder class directly on the adapter class
florina-muntenescu
added a commit
that referenced
this pull request
Feb 26, 2021
tunjid
pushed a commit
that referenced
this pull request
Jul 30, 2021
Upgrading dependencies and moving lambda code to blocks Migrating to Jetpack Bumping versions Use the stable v3.6.3 of Android Gradle Plugin instead of an alpha version Step 0 - An infinite scrolling list, using Flow and LiveData (#45) * Having the list backed by network only * Showing an infinite scrolling list, from network, with Flow * Using more KTX functionality and making the error an exception instead of string * Adding ViewBinding * Making the UI more material * Removing searchRepos helper method * Making the project compatible with Android Studio 3.6 * Step 0 - An infinite scrolling list, using Flow and LiveData * Addressing review comments: * Increasing build versions * Formatting * Added RequiresOptIn flag for coroutines and removing FlowPreview annotations * [Bug fix] Don't increment the last requested page if the request failed * Avoid duplicating data * Libraries bump and removing Room annotations from Repo Adding core-ktx as a dependency (#65) Bumping library versions (#89) Updating to alpha07 (#116) Bumping paging to alpha08 and other small deps changes (#125) Bump to paging:3.0.0-alpha09 (#129) Bump dependencies to match paging alpha11 (#139) Use RepoViewHolder instead of ViewHolder (#26) avoid casting and use the RepoViewHolder class directly on the adapter class Use RepoViewHolder instead of ViewHolder (#26) (#153) avoid casting and use the RepoViewHolder class directly on the adapter class Co-authored-by: Amir A <mcattar@gmail.com> Updating dependencies (#166) * Updating dependencies * Updating Paging 3.0 to stable Drop page size from 50 to 30 Use AbstractSavedStateViewModelFactory, pass every method what it needs directly Expose ViewModel as a singular input output interface More descriptive comments, updated code style PR feedback
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
avoid casting and use the RepoViewHolder class directly on the adapter class