Step 0 - An infinite scrolling list, using Flow and LiveData #45
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dlam
reviewed
Mar 13, 2020
app/src/main/java/com/example/android/codelabs/paging/data/GithubRepository.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/example/android/codelabs/paging/ui/SearchRepositoriesViewModel.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/example/android/codelabs/paging/data/GithubRepository.kt
Show resolved
Hide resolved
app/src/main/java/com/example/android/codelabs/paging/data/GithubRepository.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/example/android/codelabs/paging/data/GithubRepository.kt
Outdated
Show resolved
Hide resolved
ChrisCraik
reviewed
Mar 13, 2020
app/src/main/java/com/example/android/codelabs/paging/data/GithubRepository.kt
Show resolved
Hide resolved
app/src/main/java/com/example/android/codelabs/paging/data/GithubRepository.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/example/android/codelabs/paging/ui/SearchRepositoriesViewModel.kt
Outdated
Show resolved
Hide resolved
build.gradle
Outdated
| pagingVersion = '3.0.0-alpha01' | ||
| retrofitVersion = '2.6.0' | ||
| okhttpLoggingInterceptorVersion = '4.0.0' | ||
| coroutines = '1.3.0' |
There was a problem hiding this comment.
I think this is quite old, current is 1.3.70
Collaborator
Author
There was a problem hiding this comment.
the kotlin version is 1.3.70, the coroutines version seems to be 1.3.4
app/src/main/java/com/example/android/codelabs/paging/ui/SearchRepositoriesViewModel.kt
Outdated
Show resolved
Hide resolved
florina-muntenescu
force-pushed
the
step0_flow_livedata
branch
from
3f8c6bc to
b25a169
Compare
dlam
reviewed
Mar 31, 2020
build.gradle
Outdated
|
|
||
| buildscript { | ||
| ext.kotlin_version = '1.3.61' | ||
| ext.kotlin_version = '1.3.70' |
Collaborator
There was a problem hiding this comment.
Not a big deal, but 1.3.71 is out now and fixes a compiler bug which prevents usage of property delegation in inline functions!
florina-muntenescu
force-pushed
the
step0_flow_livedata
branch
3 times, most recently
from
2ebab98 to
1c6e2e8
Compare
florina-muntenescu
force-pushed
the
step0_flow_livedata
branch
2 times, most recently
from
5bd865f to
0991574
Compare
florina-muntenescu
force-pushed
the
step0_flow_livedata
branch
from
0991574 to
f82f101
Compare
* Increasing build versions * Formatting * Added RequiresOptIn flag for coroutines and removing FlowPreview annotations
florina-muntenescu
force-pushed
the
step0_flow_livedata
branch
from
f82f101 to
0f5d31d
Compare
florina-muntenescu
force-pushed
the
step0_flow_livedata
branch
from
0f5d31d to
5f35b8f
Compare
tunjid
pushed a commit
that referenced
this pull request
Jul 30, 2021
Upgrading dependencies and moving lambda code to blocks Migrating to Jetpack Bumping versions Use the stable v3.6.3 of Android Gradle Plugin instead of an alpha version Step 0 - An infinite scrolling list, using Flow and LiveData (#45) * Having the list backed by network only * Showing an infinite scrolling list, from network, with Flow * Using more KTX functionality and making the error an exception instead of string * Adding ViewBinding * Making the UI more material * Removing searchRepos helper method * Making the project compatible with Android Studio 3.6 * Step 0 - An infinite scrolling list, using Flow and LiveData * Addressing review comments: * Increasing build versions * Formatting * Added RequiresOptIn flag for coroutines and removing FlowPreview annotations * [Bug fix] Don't increment the last requested page if the request failed * Avoid duplicating data * Libraries bump and removing Room annotations from Repo Adding core-ktx as a dependency (#65) Bumping library versions (#89) Updating to alpha07 (#116) Bumping paging to alpha08 and other small deps changes (#125) Bump to paging:3.0.0-alpha09 (#129) Bump dependencies to match paging alpha11 (#139) Use RepoViewHolder instead of ViewHolder (#26) avoid casting and use the RepoViewHolder class directly on the adapter class Use RepoViewHolder instead of ViewHolder (#26) (#153) avoid casting and use the RepoViewHolder class directly on the adapter class Co-authored-by: Amir A <mcattar@gmail.com> Updating dependencies (#166) * Updating dependencies * Updating Paging 3.0 to stable Drop page size from 50 to 30 Use AbstractSavedStateViewModelFactory, pass every method what it needs directly Expose ViewModel as a singular input output interface More descriptive comments, updated code style PR feedback
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.