fixes #93 : RemoteMediator's load function throwing InvalidObjectException on first launch #94
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nction is called with LoadType.REFRESH, the keys and repos are saved to Room. When it is immediately called again with LoadType.PREPEND, the call to getRemoteKeyForFirstItem returns null and InvalidObjectException is thrown. On app restart, the keys are present and no errors are thrown
|
I also faced the same issue, but when I rolled back to the previous version of paging and room, the issue was fixed, btw, can you explain your solution? |
Comment on lines
+55
to
57
| val remoteKeys = flowOf(getRemoteKeyForFirstItem(state)) | ||
| .flowOn(Dispatchers.IO).single() | ||
| if (remoteKeys == null) { |
|
I've created the pull request, fix: RemoteMediator #112, in order to resolve this issue by disabling the Prepend load which is not being used, and to set a default value for the first load of the Append load type. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On initial app start,
GithubRemoteMediator's load function is called withLoadType.REFRESH, the keys and repos are saved to Room. When it is immediately called again withLoadType.PREPEND, the call togetRemoteKeyForFirstItemreturns null andInvalidObjectExceptionis thrown. On app restart, the keys are present and no errors are thrown.I am sure that this is not the optimal solution and would appreciate any feedback or guidance.
Thanks much!
-Alexi