Skip to content

fixes #93 : RemoteMediator's load function throwing InvalidObjectException on first launch #94

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

fixes #93 : RemoteMediator's load function throwing InvalidObjectException on first launch #94

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion app/src/main/java/com/example/android/codelabs/paging/data/GithubRemoteMediator.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,10 @@ import com.example.android.codelabs.paging.api.IN_QUALIFIER
import com.example.android.codelabs.paging.db.RemoteKeys
import com.example.android.codelabs.paging.db.RepoDatabase
import com.example.android.codelabs.paging.model.Repo
import kotlinx.coroutines.Dispatchers
import kotlinx.coroutines.flow.flowOf
import kotlinx.coroutines.flow.flowOn
import kotlinx.coroutines.flow.single
import retrofit2.HttpException
import java.io.IOException
import java.io.InvalidObjectException
Expand All @@ -48,7 +52,8 @@ class GithubRemoteMediator(
remoteKeys?.nextKey?.minus(1) ?: GITHUB_STARTING_PAGE_INDEX
}
LoadType.PREPEND -> {
val remoteKeys = getRemoteKeyForFirstItem(state)
val remoteKeys = flowOf(getRemoteKeyForFirstItem(state))
.flowOn(Dispatchers.IO).single()
if (remoteKeys == null) {
Comment on lines +55 to 57
Copy link

@yangjunfei-lotus yangjunfei-lotus Sep 1, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still crash on first launch

// The LoadType is PREPEND so some data was loaded before,
// so we should have been able to get remote keys
Expand Down