Skip to content

Conversation

@cy245
Copy link
Contributor

@cy245 cy245 commented Oct 24, 2025

Remove mentions of glitch.me and provide general overview of the app design.

@cy245 cy245 requested a review from niharika2810 as a code owner October 24, 2025 17:15
@gemini-code-assist
Copy link

Summary of Changes

Hello @cy245, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request primarily updates the Shrine/README.md file to enhance its accuracy and utility. The changes involve removing obsolete information related to glitch.me server configurations and introducing a detailed overview of the application's design and architecture. The goal is to provide a more relevant and helpful guide for understanding the Shrine sample app's structure and its current user interaction flows.

Highlights

  • README Refactor: The Shrine/README.md file has undergone a significant refactor to improve clarity and provide a more current overview of the application.
  • Glitch.me Backend Removal: All outdated references and setup instructions for using glitch.me as a backend server have been completely removed from the documentation.
  • App Design Overview Added: A new 'Design' section has been introduced, offering a high-level explanation of the app's architecture, including its server integration, component responsibilities (Screens, View Models, Credential Manager), and data flow.
  • Updated User Flow: The 'Typical account creation and login flow' section has been revised to reflect current features such as passkey-only account creation, Sign in with Google, and passkey management, simplifying the user journey descriptions.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the Shrine README to remove mentions of glitch.me and provide a general overview of the app design. The changes include renaming the app title, updating the features list, revising the account creation and login flow, and adding a design section that covers the app's architecture, server, screens, view models, credential manager, and requests/responses. I have provided a review comment to address a potential issue.

@cy245 cy245 merged commit d3454bb into main Oct 27, 2025
4 checks passed
@cy245 cy245 deleted the update-shrine-readme branch October 27, 2025 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants