Add conditional create functionality. Also add own debug signing key for unique asset linking sha#196
Add conditional create functionality. Also add own debug signing key for unique asset linking sha#196
Conversation
…for unique asset linking sha
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request introduces passkey creation support in the CredentialProviderService and refactors related logic into a new PasskeyUtils class. Key changes include updating library versions, configuring app signing, and implementing silent passkey finalization. Feedback focuses on critical security and stability issues: sensitive signing keys should not be committed to version control, and the build script needs better error handling for missing properties and resource management. Additionally, network operations in PasskeyUtils should be asynchronous to avoid ANR errors, and the service must properly report validation failures via the callback. Other recommendations include improving method encapsulation, simplifying conditional logic, and ensuring proper exception logging and file formatting.
...p/src/main/java/com/example/android/authentication/myvault/data/CredentialProviderService.kt
Show resolved
Hide resolved
...er/MyVault/app/src/main/java/com/example/android/authentication/myvault/util/PasskeyUtils.kt
Show resolved
Hide resolved
...p/src/main/java/com/example/android/authentication/myvault/data/CredentialProviderService.kt
Outdated
Show resolved
Hide resolved
...p/src/main/java/com/example/android/authentication/myvault/data/CredentialProviderService.kt
Outdated
Show resolved
Hide resolved
...ult/app/src/main/java/com/example/android/authentication/myvault/ui/CreatePasskeyActivity.kt
Show resolved
Hide resolved
...er/MyVault/app/src/main/java/com/example/android/authentication/myvault/util/PasskeyUtils.kt
Outdated
Show resolved
Hide resolved
...er/MyVault/app/src/main/java/com/example/android/authentication/myvault/util/PasskeyUtils.kt
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Code Review
This pull request introduces support for passkey conditional creation by implementing onCreateCredentialRequest in CredentialProviderService and adding a PasskeyUtils utility class for credential handling. It also updates the credentials and providerevents libraries and configures signing settings. My feedback highlights that assert statements in PasskeyUtils.kt should be replaced with require() or check() for reliable runtime validation in production, and recommends cleaning up commented-out code in CredentialProviderService.kt to avoid confusion regarding conditional create logic.
No description provided.