Make VerifierCli use an InstantSource for time.#68
Merged
copybara-service[bot] merged 1 commit intomainfrom Mar 9, 2026
Merged
Make VerifierCli use an InstantSource for time.#68copybara-service[bot] merged 1 commit intomainfrom
copybara-service[bot] merged 1 commit intomainfrom
Conversation
copybara-service
bot
force-pushed
the
test_880910380
branch
from
cdb36f7 to
e2290c1
Compare
The test data is fixed in time, but the test systems keep moving forward. Extract an appropriate validity timestamp from the test data and pass it to Verifier to ensure tests don't start failing when cert timestamps go out of their validity time. PiperOrigin-RevId: 880939905
copybara-service
bot
force-pushed
the
test_880910380
branch
from
e2290c1 to
b1b56db
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make VerifierCli use an InstantSource for time.
The test data is fixed in time, but the test systems keep moving forward.
Extract an appropriate validity timestamp from the test data and pass it to
Verifier to ensure tests don't start failing when cert timestamps go out of
their validity time.