-
Notifications
You must be signed in to change notification settings - Fork 90
Add markdown version of migration guide #138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @dturner, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request updates the Navigation 3 migration guide by converting it to a more standardized markdown format, enhancing its utility for AI agents, and providing comprehensive code examples for implementing Navigation 3's state management. The changes aim to clarify the migration process from Navigation 2 to Navigation 3, particularly concerning the replacement of Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates the migration guide from Navigation 2 to Navigation 3. The changes include adding detailed code snippets for NavigationState and Navigator, clarifying several steps, fixing typos, and improving the markdown formatting by using semantic table headers and removing processor-specific syntax. The guide is now more comprehensive and easier to follow. I've suggested a couple of improvements to the new code snippets to fix a bug and make the code more idiomatic.
| val stacksInUse: List<NavKey> | ||
| get(){ | ||
| val stacksInUse = mutableListOf(startRoute) | ||
| if (topLevelRoute != startRoute) stacksInUse += topLevelRoute | ||
| return stacksInUse | ||
| } | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The implementation of the stacksInUse computed property can be simplified to be more concise and idiomatic. Using an if/else expression is cleaner than creating and modifying a mutable list.
| val stacksInUse: List<NavKey> | |
| get(){ | |
| val stacksInUse = mutableListOf(startRoute) | |
| if (topLevelRoute != startRoute) stacksInUse += topLevelRoute | |
| return stacksInUse | |
| } | |
| } | |
| val stacksInUse: List<NavKey> | |
| get() = if (topLevelRoute == startRoute) { | |
| listOf(startRoute) | |
| } else { | |
| listOf(startRoute, topLevelRoute) | |
| } |
| val currentStack = state.backStacks[state.topLevelRoute] ?: | ||
| error("Stack for $state.topLevelRoute not found") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The string template in the error message is incorrect. It should use curly braces ${...} to correctly interpolate the topLevelRoute property of the state object. Without them, it will call toString() on the state object and append the literal string .topLevelRoute, which can be misleading when debugging.
| val currentStack = state.backStacks[state.topLevelRoute] ?: | |
| error("Stack for $state.topLevelRoute not found") | |
| val currentStack = state.backStacks[state.topLevelRoute] ?: | |
| error("Stack for ${state.topLevelRoute} not found") |
No description provided.