Skip to content

Conversation

@dturner
Copy link
Collaborator

@dturner dturner commented Nov 24, 2025

See #151

This commit introduces a `CompositionLocal` to control the visibility of the back button in the detail screen.

When the list-detail recipe is displayed in a two-pane layout on larger screens, the detail pane no longer shows a back button, as navigation is handled by the list pane. The back button remains visible in the single-pane view on smaller devices.

Fixes #151
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @dturner, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the list-detail flow by introducing a flexible way to manage the visibility of a back button on the detail pane. It leverages Jetpack Compose's CompositionLocal to allow the detail screen to adapt its UI based on the surrounding layout, specifically hiding the back button when the detail view is presented alongside the list in a two-pane configuration. This ensures a streamlined user experience across different screen sizes and layouts.

Highlights

  • Dynamic Back Button Visibility: Implemented a mechanism to control the visibility of a back button on the detail pane using a CompositionLocal.
  • Two-Pane Layout Adaptation: The back button is now conditionally hidden when the detail pane is displayed in a two-pane layout, providing a more contextually appropriate UI.
  • Back Navigation Integration: The detail screen now accepts an onBack callback, which is wired to pop the navigation back stack, enabling proper navigation when the back button is visible.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a mechanism to control the visibility of a back button in the detail pane, which is a great addition for improving the user experience in list-detail layouts. The implementation cleverly uses CompositionLocal to communicate the visibility state from the ListDetailScene down to the ConversationDetailScreen. When in a two-pane layout, the back button is hidden, and when in a single-pane layout, it's shown, with its action correctly wired to navigate back. The changes are well-structured, clean, and effectively demonstrate the intended pattern. Overall, this is a high-quality contribution.

This commit updates the `README.md` for the list-detail recipe to document the `LocalBackButtonVisibility` `CompositionLocal`.

The README now explains that this `CompositionLocal` allows a detail screen to conditionally hide its back button when displayed within a `ListDetailScene`.
@dturner dturner merged commit 10e9f09 into main Nov 26, 2025
2 checks passed
@dturner dturner deleted the dt/back-button-visibility branch November 26, 2025 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants