-
Notifications
You must be signed in to change notification settings - Fork 85
Show how to control the visibility of a back button on the detail pane #152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This commit introduces a `CompositionLocal` to control the visibility of the back button in the detail screen. When the list-detail recipe is displayed in a two-pane layout on larger screens, the detail pane no longer shows a back button, as navigation is handled by the list pane. The back button remains visible in the single-pane view on smaller devices. Fixes #151
Summary of ChangesHello @dturner, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the list-detail flow by introducing a flexible way to manage the visibility of a back button on the detail pane. It leverages Jetpack Compose's Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces a mechanism to control the visibility of a back button in the detail pane, which is a great addition for improving the user experience in list-detail layouts. The implementation cleverly uses CompositionLocal to communicate the visibility state from the ListDetailScene down to the ConversationDetailScreen. When in a two-pane layout, the back button is hidden, and when in a single-pane layout, it's shown, with its action correctly wired to navigate back. The changes are well-structured, clean, and effectively demonstrate the intended pattern. Overall, this is a high-quality contribution.
This commit updates the `README.md` for the list-detail recipe to document the `LocalBackButtonVisibility` `CompositionLocal`. The README now explains that this `CompositionLocal` allows a detail screen to conditionally hide its back button when displayed within a `ListDetailScene`.
See #151