Is there an existing issue for this?
Describe the problem
TopicScreen still contains a few hardcoded user-facing strings instead of string resources:
NiaLoadingWheel(contentDesc = "Loading news")Text("Error")Text("FOLLOWING")Text("NOT FOLLOWING")
These strings are rendered from feature/topic/impl/src/main/kotlin/com/google/samples/apps/nowinandroid/feature/topic/impl/TopicScreen.kt.
Keeping them inline makes the topic screen less consistent with the rest of the app and prevents these labels and content descriptions from being localized.
This is separate from #2108 / #2109, which address the TopicUiState.Error -> TODO() crash. PR #2109 explicitly leaves these remaining TopicScreen TODOs out of scope.
Describe the solution
Move the remaining user-facing strings in TopicScreen to string resources and read them through stringResource, following the existing resource naming conventions for the topic feature.
Additional context
No response
Code of Conduct
Is there an existing issue for this?
Describe the problem
TopicScreenstill contains a few hardcoded user-facing strings instead of string resources:NiaLoadingWheel(contentDesc = "Loading news")Text("Error")Text("FOLLOWING")Text("NOT FOLLOWING")These strings are rendered from
feature/topic/impl/src/main/kotlin/com/google/samples/apps/nowinandroid/feature/topic/impl/TopicScreen.kt.Keeping them inline makes the topic screen less consistent with the rest of the app and prevents these labels and content descriptions from being localized.
This is separate from #2108 / #2109, which address the
TopicUiState.Error -> TODO()crash. PR #2109 explicitly leaves these remainingTopicScreenTODOs out of scope.Describe the solution
Move the remaining user-facing strings in
TopicScreento string resources and read them throughstringResource, following the existing resource naming conventions for the topic feature.Additional context
No response
Code of Conduct