Finalize bump agp 9.0 (enable newDsl)#2054
Conversation
Change-Id: I9f4174946f043c79bba9a669655f6654036b5679
Change-Id: I20ca1f71610f26a18d4573b3122994bc32c18723
Change-Id: Ifb855133593f64771e81f60b96c3e34d946dac8f
Summary of ChangesHello @Jaehwa-Noh, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request finalizes the integration of Android Gradle Plugin 9.0 by enabling its new DSL. It resolves previous compatibility issues by updating the protobuf Gradle plugin and adapting the build configuration of the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request successfully finalizes the bump to AGP 9.0 by enabling the newDsl feature. The changes include migrating the core/datastore-proto module from an Android library to a JVM library, removing the now-unnecessary android configuration block, and updating the protobuf plugin version to 0.9.6. Additionally, the Gradle build script for protobuf task configuration was improved by using configureEach and named for better performance and correctness. All changes are well-aligned with the pull request's objective.
Change-Id: I3df518dd4a5f37ba7ca6e568914783b1ea417fce
Jaehwa-Noh
changed the title
|
@liutikas PTAL |
|
This is an ugly workaround. Instead we just need to wait for protobuf plugin to get fixed. |
|
@liutikas Is there any reason datastore-protobuf to be Android library? Does protobuf need android dependency? |
After another pass, you are right, this can just be JVM. |
|
@liutikas Thank you to review it again. |
…oto JVM module protobuf-gradle-plugin 0.9.6 casts to BaseExtension (removed in AGP 9), breaking on Android modules. JVM modules don't touch Android APIs, so moving proto generation to :data:proto sidesteps the issue entirely. Same approach as Now in Android (android/nowinandroid#2054). Validated: generateProto + compileKotlin succeeds on :data:proto. All 7 toolchain compatibility checks now PASS. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
2 participants
What I have done and why
Finally enable newDsl that bump AGP 9.0 totally.