Offline-first UX improvements #304
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
tunjid
force-pushed
the
tj/sync-ui
branch
4 times, most recently
from
8ad00bb to
e7901f2
Compare
alexvanyo
reviewed
Sep 26, 2022
...ava/com/google/samples/apps/nowinandroid/core/data/util/ConnectivityManagerNetworkMonitor.kt
Outdated
Show resolved
Hide resolved
...ava/com/google/samples/apps/nowinandroid/core/data/util/ConnectivityManagerNetworkMonitor.kt
Show resolved
Hide resolved
.../foryou/src/main/java/com/google/samples/apps/nowinandroid/feature/foryou/ForYouViewModel.kt
Outdated
Show resolved
Hide resolved
...c/main/java/com/google/samples/apps/nowinandroid/sync/status/WorkManagerSyncStatusMonitor.kt
Outdated
Show resolved
Hide resolved
alexvanyo
reviewed
Sep 26, 2022
.../foryou/src/main/java/com/google/samples/apps/nowinandroid/feature/foryou/ForYouViewModel.kt
Outdated
Show resolved
Hide resolved
alexvanyo
reviewed
Sep 26, 2022
.../foryou/src/main/java/com/google/samples/apps/nowinandroid/feature/foryou/ForYouViewModel.kt
Show resolved
Hide resolved
tunjid
force-pushed
the
tj/sync-ui
branch
4 times, most recently
from
10ad113 to
4b8e342
Compare
alexvanyo
reviewed
Sep 27, 2022
...ure/foryou/src/main/java/com/google/samples/apps/nowinandroid/feature/foryou/ForYouScreen.kt
Outdated
Show resolved
Hide resolved
alexvanyo
approved these changes
Sep 27, 2022
Contributor
alexvanyo
left a comment
alexvanyo
left a comment
There was a problem hiding this comment.
New loading logic looks good to me!
tunjid
force-pushed
the
tj/sync-ui
branch
5 times, most recently
from
aa93227 to
7e372b5
Compare
alexvanyo
approved these changes
Sep 30, 2022
Contributor
alexvanyo
left a comment
alexvanyo
left a comment
There was a problem hiding this comment.
Looks good, just some minor nits
...c/main/java/com/google/samples/apps/nowinandroid/core/designsystem/component/LoadingWheel.kt
Outdated
Show resolved
Hide resolved
...ure/foryou/src/main/java/com/google/samples/apps/nowinandroid/feature/foryou/ForYouScreen.kt
Outdated
Show resolved
Hide resolved
Change-Id: I10a646e8a17f81d96351e69d36f0cb6ccf28e05c
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This CL improves the offline-first story by clearly communicating to the user:
It also adds two utilities:
NetworkMonitorfor checking when onlineSyncStatusMonitorfor checking when sync is running.Implementations delegate to
ConnectivityManagerandWorkManagerrespectively.