Skip to content

Conversation

@romanofranz
Copy link
Contributor

@romanofranz romanofranz commented Nov 3, 2025

  • Updated to Jetpack WindowManager 1.5 and added demo for new WindowSize Classes
  • Updated minSdk to 24 to support the newest Jetpack libraries

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @romanofranz, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request updates the Jetpack WindowManager library to its latest stable version, 1.5.0, and integrates the new WindowSize Classes introduced in this release. The changes demonstrate how to leverage the expanded width breakpoints, specifically 'LARGE' and 'EXTRA-LARGE', to enable more sophisticated responsive UI layouts across a broader spectrum of device screen sizes and form factors.

Highlights

  • Dependency Update: The androidx-window dependency has been updated from version 1.4.0-rc01 to 1.5.0 in gradle/libs.versions.toml.
  • New WindowSizeClass Breakpoints: The WindowMetricsActivity.kt file now imports and utilizes new WindowSizeClass constants: WIDTH_DP_EXTRA_LARGE_LOWER_BOUND and WIDTH_DP_LARGE_LOWER_BOUND.
  • Updated Window Size Class Computation: The computeWindowSizeClass method in WindowMetricsActivity.kt has been updated to use WindowSizeClass.BREAKPOINTS_V2, which incorporates the newly introduced breakpoints.
  • Expanded Width Size Class Logic: The getWidthSizeClass function in WindowMetricsActivity.kt has been extended to include logic for the new EXTRA-LARGE and LARGE width size classes, providing more granular UI adaptation.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the Jetpack WindowManager dependency to version 1.5 and adds a demonstration of the new WindowSize Classes. The changes are correct and effectively showcase the new APIs. I have one minor suggestion to improve code style and conciseness.

@romanofranz romanofranz merged commit f02e8e9 into main Nov 4, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants