Modify AGP 9 upgrade skill#12
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the AGP 9 upgrade skill documentation to explicitly exclude Kotlin Multiplatform (KMP) projects and adds a new step for updating dependencies like KSP and Hilt. It also reorganizes the migration steps and introduces a new guidelines section in the recipes documentation to enforce the use of public APIs and specific reference repositories. The review feedback suggests improving consistency in the step headers by standardizing the use of colons and removing trailing periods, as well as correcting a grammatical error in the kapt migration description.
|
|
||
| If Hilt is used in the project, ensure it is on version 2.59.2 or higher. | ||
|
|
||
| ### Step 2: Migrate to built-in Kotlin. |
There was a problem hiding this comment.
For consistency with Step 1, consider removing the trailing period from the header.
| ### Step 2: Migrate to built-in Kotlin. | |
| ### Step 2: Migrate to built-in Kotlin |
| See [the guide](references/android/build/migrate-to-built-in-kotlin.md) for detailed information. | ||
|
|
||
| ### Step 2. Migrate to the new AGP DSL. | ||
| ### Step 3. Migrate to the new AGP DSL. |
There was a problem hiding this comment.
The header formatting is inconsistent. Use a colon after the step number and remove the trailing period to match the style of Step 1.
| ### Step 3. Migrate to the new AGP DSL. | |
| ### Step 3: Migrate to the new AGP DSL |
|
|
||
| If KSP (`com.google.devtools.ksp`) is used in the project, ensure it is on | ||
| version 2.3.6 or higher. | ||
| ### Step 4. Migrate kapt to KSP or legacy-kapt |
There was a problem hiding this comment.
Use a colon after the step number for consistency with the previous steps.
| ### Step 4. Migrate kapt to KSP or legacy-kapt | |
| ### Step 4: Migrate kapt to KSP or legacy-kapt |
| If KSP (`com.google.devtools.ksp`) or kapt (`org.jetbrains.kotlin.kapt`) are | ||
| used in the project, [KSP, kapt, and legacy-kapt](references/ksp-kapt.md) | ||
| for detailed migration steps. |
There was a problem hiding this comment.
The sentence is grammatically incomplete and uses 'are' with a singular 'or' construction. It should include a verb like 'see' and use 'is' for grammatical correctness.
| If KSP (`com.google.devtools.ksp`) or kapt (`org.jetbrains.kotlin.kapt`) are | |
| used in the project, [KSP, kapt, and legacy-kapt](references/ksp-kapt.md) | |
| for detailed migration steps. | |
| If KSP (`com.google.devtools.ksp`) or kapt (`org.jetbrains.kotlin.kapt`) is | |
| used in the project, see [KSP, kapt, and legacy-kapt](references/ksp-kapt.md) | |
| for detailed migration steps. |
| for detailed migration steps. | ||
|
|
||
| ### Step 4. BuildConfig | ||
| ### Step 5. BuildConfig |
There was a problem hiding this comment.
Use a colon after the step number for consistency.
| ### Step 5. BuildConfig | |
| ### Step 5: BuildConfig |
| for detailed information. | ||
|
|
||
| ### Step 5. Update gradle.properties | ||
| ### Step 6. Update gradle.properties |
There was a problem hiding this comment.
Use a colon after the step number for consistency.
| ### Step 6. Update gradle.properties | |
| ### Step 6: Update gradle.properties |
|
interestingly I added this skill and it applied it to a KMP project and I could not finish the upgrade in the end. Is there a way to make the rule "not applicable to KMP projects" more obvious to an LLM? |
3 participants
Minor changes to the skill, including stating that it's for non-KMP projects.