-
Notifications
You must be signed in to change notification settings - Fork 288
Add location snippet #652
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Add location snippet #652
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
86 changes: 86 additions & 0 deletions
86
wear/src/main/java/com/example/wear/snippets/location/LocationActivity.kt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,86 @@ | ||
| /* | ||
| * Copyright 2025 The Android Open Source Project | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * https://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| package com.example.wear.snippets.location | ||
|
|
||
| import android.content.pm.PackageManager | ||
| import android.os.Bundle | ||
| import androidx.activity.ComponentActivity | ||
| import androidx.activity.compose.setContent | ||
| import androidx.compose.foundation.layout.fillMaxWidth | ||
| import androidx.compose.runtime.Composable | ||
| import androidx.compose.ui.Modifier | ||
| import androidx.wear.compose.foundation.lazy.TransformingLazyColumn | ||
| import androidx.wear.compose.foundation.lazy.rememberTransformingLazyColumnState | ||
| import androidx.wear.compose.material3.ListHeader | ||
| import androidx.wear.compose.material3.ScreenScaffold | ||
| import androidx.wear.compose.material3.Text | ||
| import com.google.android.horologist.compose.layout.AppScaffold | ||
| import com.google.android.horologist.compose.layout.ColumnItemType | ||
| import com.google.android.horologist.compose.layout.rememberResponsiveColumnPadding | ||
|
|
||
|
|
||
| // [START android_wear_location] | ||
| class LocationActivity : ComponentActivity() { | ||
| override fun onCreate(savedInstanceState: Bundle?) { | ||
| super.onCreate(savedInstanceState) | ||
|
|
||
| // [START_EXCLUDE] | ||
| setContent { | ||
| WearApp(hasGps = { hasGps() }) | ||
| } | ||
| // [END_EXCLUDE] | ||
| } | ||
| fun hasGps(): Boolean = | ||
| packageManager.hasSystemFeature(PackageManager.FEATURE_LOCATION_GPS) | ||
| } | ||
| // [END android_wear_location] | ||
|
|
||
| @Composable | ||
| fun WearApp(hasGps: () -> Boolean) { | ||
|
|
||
| val columnState = rememberTransformingLazyColumnState() | ||
| val contentPadding = rememberResponsiveColumnPadding( | ||
| first = ColumnItemType.ListHeader, | ||
| last = ColumnItemType.Button, | ||
| ) | ||
| AppScaffold { | ||
| ScreenScaffold( | ||
| scrollState = columnState, | ||
| contentPadding = contentPadding | ||
| ) { contentPadding -> | ||
| TransformingLazyColumn( | ||
| state = columnState, | ||
| contentPadding = contentPadding | ||
| ) { | ||
| item { | ||
| ListHeader( | ||
| modifier = Modifier.fillMaxWidth() | ||
| ) { | ||
| if (!hasGps()) { | ||
| Text(text = "This hardware doesn't have GPS") | ||
| // Fall back to functionality that doesn't use location or | ||
| // warn the user that location function isn't available. | ||
| } | ||
| else { | ||
| Text(text = "This hardware has GPS") | ||
| } | ||
| } | ||
| } | ||
| } | ||
| } | ||
| } | ||
| } | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How do hasSystemFeature(PackageManager.FEATURE_LOCATION_GPS) and LocationManagerCompat.isLocationEnabled(locationManager) interoperate and is the latter relevant here?
For example, if the watch has GPS, but Location is disabled in the settings, do these return true and false respectively, and does that matter in this use case?
Or does FEATURE_LOCATION_GPS already take into account whether location is enabled by the location setting?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for raising, it does NOT take into account whether location is enabled by the user setting. The current documentation doesn't mention it but I can add a new section and also mention this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rereading https://developer.android.com/training/wearables/apps/location-detection#DetectGPS, this is for GPS only and there is another section for requesting permissions and in https://developer.android.com/develop/sensors-and-location/location/retrieve-current?#last-known (which is linked from the same page) it explains what happens when location is tuned off in settings.
In summary: I think this snippet works as it is as this section is only focusing on gps, other sections of the same page cover the other cases.