-
Notifications
You must be signed in to change notification settings - Fork 287
Add a new project for DataStore #663
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b7a0da5 to
b617465
Compare
riggaroo
approved these changes
Oct 22, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mostly lgtm, just some questions
datastore/src/androidTest/java/com/example/datastore/snippets/ProtoDataStoreTest.kt
Outdated
Show resolved
Hide resolved
datastore/src/androidTest/java/com/example/datastore/snippets/DataStoreSnippetsTest.kt
Show resolved
Hide resolved
datastore/src/main/java/com/example/datastore/snippets/json/JsonDataStoreScreen.kt
Show resolved
Hide resolved
...ore/src/main/java/com/example/datastore/snippets/multiprocess/MultiProcessDataStoreScreen.kt
Show resolved
Hide resolved
datastore/src/main/java/com/example/datastore/snippets/multiprocess/TimestampUpdateService.kt
Outdated
Show resolved
Hide resolved
datastore/src/test/java/com/example/datastore/snippets/ExampleUnitTest.kt
Outdated
Show resolved
Hide resolved
misc/src/main/java/com/example/snippets/ActivityEmbeddingJavaSnippets.java
Outdated
Show resolved
Hide resolved
a0a5407 to
be37aba
Compare
|
Rebecca, can you take another look at this? This is my first GitHub PR so I didn't realize that I needed to send a separate commit (I amended my commit like we do in Gerrit) So some of the comments don't match the previous line numbers. Sorry! |
riggaroo
approved these changes
Oct 24, 2025
be37aba to
0a5fa40
Compare
The data store details on DAC has inline code snippets https://developer.android.com/topic/libraries/architecture/datastore This PR adds code samples that can be used as snippets on DAC.
0a5fa40 to
3ea0a89
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The data store details on DAC has inline code snippets https://developer.android.com/topic/libraries/architecture/datastore
This PR adds code samples that can be used as snippets on DAC.
It provides samples to create 3 different kinds of data store implementations:
It also provides an example that demonstrates how to create a data store that can be accessed from multiple processes.