Skip to content

Add initial cars snippets#852

Merged
yrezgui merged 10 commits intomainfrom
cars-migration
Apr 13, 2026
Merged

Add initial cars snippets#852
yrezgui merged 10 commits intomainfrom
cars-migration

Conversation

@jankleinert
Copy link
Copy Markdown
Contributor

Sets up the structure for snippets for Android for Cars and adds a few initial snippets.

The migrated snippets are in:

  • cars/src/main/java/com/example/cars/apps/AutomotiveOS.kt
  • cars/src/main/java/com/example/cars/apps/IOT.kt
  • cars/src/main/java/com/example/cars/apps/POI.kt
  • cars/src/main/java/com/example/cars/apps/library/StartScreen.kt

@snippet-bot
Copy link
Copy Markdown

snippet-bot bot commented Mar 27, 2026

Here is the summary of changes.

You are about to add 4 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@jankleinert jankleinert requested a review from t-weathers March 27, 2026 14:29
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a new Android module named 'cars' that provides code snippets for Android Automotive OS and Android Auto. The changes include the necessary build configurations, manifest declarations, and several screen implementations demonstrating the use of GridTemplate, PlaceListMapTemplate, and PaneTemplate. Review feedback suggests replacing the empty 'ic_garage.xml' selector with a functional vector drawable and updating the 'app_name' string to a human-readable value instead of the package name.

limitations under the License.
-->
<resources>
<string name="app_name">com.example.cars</string>
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The app_name string is currently set to the package name. For better user experience and clarity, it should be a human-readable name.

Suggested change
<string name="app_name">com.example.cars</string>
<string name="app_name">Cars Snippets</string>

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jankleinert Worth updating it?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will update this when I fix the ic_garage.xml file.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated the app name in this file.

Copy link
Copy Markdown
Contributor

@yrezgui yrezgui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good but still want Thomas or Paul to review it as they have more context to Android Auto

limitations under the License.
-->
<resources>
<string name="app_name">com.example.cars</string>
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jankleinert Worth updating it?

@yrezgui yrezgui requested a review from pflammertsma March 31, 2026 12:04
@yrezgui yrezgui enabled auto-merge (squash) April 13, 2026 14:56
@yrezgui yrezgui merged commit 955bf61 into main Apr 13, 2026
6 checks passed
@yrezgui yrezgui deleted the cars-migration branch April 13, 2026 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants