Conversation
|
Here is the summary of changes. You are about to add 4 region tags.
This comment is generated by snippet-bot.
|
There was a problem hiding this comment.
Code Review
This pull request introduces a new Android module named 'cars' that provides code snippets for Android Automotive OS and Android Auto. The changes include the necessary build configurations, manifest declarations, and several screen implementations demonstrating the use of GridTemplate, PlaceListMapTemplate, and PaneTemplate. Review feedback suggests replacing the empty 'ic_garage.xml' selector with a functional vector drawable and updating the 'app_name' string to a human-readable value instead of the package name.
cars/src/main/res/values/strings.xml
Outdated
| limitations under the License. | ||
| --> | ||
| <resources> | ||
| <string name="app_name">com.example.cars</string> |
There was a problem hiding this comment.
Will update this when I fix the ic_garage.xml file.
There was a problem hiding this comment.
Updated the app name in this file.
yrezgui
left a comment
There was a problem hiding this comment.
Looks good but still want Thomas or Paul to review it as they have more context to Android Auto
cars/src/main/res/values/strings.xml
Outdated
| limitations under the License. | ||
| --> | ||
| <resources> | ||
| <string name="app_name">com.example.cars</string> |
Sets up the structure for snippets for Android for Cars and adds a few initial snippets.
The migrated snippets are in: