Merged
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a set of CameraX code snippets for both Jetpack Compose and View-based implementations, covering initialization, previewing, tap-to-focus, and image capture. It also updates the CameraX dependency version to 1.6.0. Feedback includes wrapping camera initialization in a LaunchedEffect to prevent side effects during recomposition, correcting the version reference for the viewfinder-compose library which typically follows a different versioning cycle, and adding a null-safe check for the display rotation access to avoid potential NullPointerExceptions.
compose/snippets/src/main/java/com/example/compose/snippets/camerax/Camera1ToCameraXSnippets.kt
Outdated
Show resolved
Hide resolved
compose/snippets/src/main/java/com/example/compose/snippets/camerax/Camera1ToCameraXSnippets.kt
Outdated
Show resolved
Hide resolved
yrezgui
reviewed
Apr 8, 2026
yrezgui
requested changes
Apr 8, 2026
compose/snippets/src/main/java/com/example/compose/snippets/camerax/Camera1ToCameraXSnippets.kt
Outdated
Show resolved
Hide resolved
92e0dcb to
39429b3
Compare
camerax/src/main/java/com/example/camerax/snippets/Camera1ToCameraXSnippets.kt
Outdated
Show resolved
Hide resolved
JoseAlcerreca
approved these changes
Apr 9, 2026
yrezgui
approved these changes
Apr 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.