Added snippets for verified email feature via Credential Manager API#867
Merged
Added snippets for verified email feature via Credential Manager API#867
Conversation
yrezgui
requested changes
Apr 9, 2026
...entialmanager/src/main/java/com/example/identity/credentialmanager/VerifiedEmailFunctions.kt
Outdated
Show resolved
Hide resolved
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a new utility class, VerifiedEmailFunctions, to handle interactions with the Credential Manager for verified email credentials. It includes functions for constructing OpenID4VP requests, extracting verified user information from SD-JWTs, and creating accounts with verified emails. The review suggests defining a TAG constant for logging and refactoring duplicated SD-JWT parsing logic into a shared helper function to improve maintainability and robustness.
...entialmanager/src/main/java/com/example/identity/credentialmanager/VerifiedEmailFunctions.kt
Show resolved
Hide resolved
...entialmanager/src/main/java/com/example/identity/credentialmanager/VerifiedEmailFunctions.kt
Show resolved
Hide resolved
...entialmanager/src/main/java/com/example/identity/credentialmanager/VerifiedEmailFunctions.kt
Show resolved
Hide resolved
...entialmanager/src/main/java/com/example/identity/credentialmanager/VerifiedEmailFunctions.kt
Show resolved
Hide resolved
cy245
reviewed
Apr 9, 2026
...entialmanager/src/main/java/com/example/identity/credentialmanager/VerifiedEmailFunctions.kt
Show resolved
Hide resolved
...entialmanager/src/main/java/com/example/identity/credentialmanager/VerifiedEmailFunctions.kt
Outdated
Show resolved
Hide resolved
...entialmanager/src/main/java/com/example/identity/credentialmanager/VerifiedEmailFunctions.kt
Show resolved
Hide resolved
…for raw response example
…ied_email_snippets
cy245
approved these changes
Apr 10, 2026
yrezgui
approved these changes
Apr 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.