Telecom sanitization#881
Conversation
Refactor and simplify telecom sample apps * Remove unused color resources and simplify themes * Prune unnecessary dependencies from Dialer and VoIP build files * Simplify Dialer MainActivity UI and remove unused Compose previews * Update app names for Dialer and VoIP modules * Remove unused lifecycle-livedata-ktx library reference from catalog
* Standardize snippet tags using bracketed format * Remove redundant color and theme resource files * Update UI layout and text in dialer and voipapp * Remove redundant activity label in manifest
* Add fillMaxSize to Box modifiers in VoipCallbackActivity and MainActivity * Fix indentation for call log URI snippet tag
|
Here is the summary of changes. You are about to add 6 region tags.
You are about to delete 2 region tags.
This comment is generated by snippet-bot.
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request streamlines the dependencies for the dialer and voipapp modules, updates code snippet tags to the standard bracketed format, and refactors the UI of MainActivity and VoipCallbackActivity to use a centered Box layout. Additionally, it updates application names and removes redundant resource files. Feedback was provided regarding redundant padding in the VoipCallbackActivity layout that could lead to layout inconsistencies.
* Merge dialer and voipapp sub-modules into a single telecom module * Rename MainActivity to DialerActivity * Rename VoipCallbackActivity to VoipCallActivity * Update package structure and consolidate resources * Update settings.gradle.kts to reflect module changes
|
Merged the two seperate modules in to one to optimize build times. |
| @@ -1,2 +1,3 @@ | |||
| /build | |||
| /src/androidTest/ | |||
There was a problem hiding this comment.
For lines 2 and 3, I don't think we want to ignore these files in the src folders, right? Even if it's not needed now, someone in the future may add some files here and may wonder why it's not getting picked up for their commit.
2 participants
sanitized the code by addressing comments from PR 876
fixed syntax of snippet's region tags.