Skip to content

Identity add issuance attestation snippets#886

Merged
cy245 merged 6 commits into
mainfrom
identity_add_issuance_attestation
Apr 23, 2026
Merged

Identity add issuance attestation snippets#886
cy245 merged 6 commits into
mainfrom
identity_add_issuance_attestation

Conversation

@cy245
Copy link
Copy Markdown
Contributor

@cy245 cy245 commented Apr 23, 2026

No description provided.

@cy245 cy245 requested review from kkuan2011 and yrezgui as code owners April 23, 2026 21:32
@snippet-bot
Copy link
Copy Markdown

snippet-bot Bot commented Apr 23, 2026

Here is the summary of changes.

You are about to add 4 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds a digital_credential_snippets section to jsonSnippets.json, providing JSON schemas and examples for Android Keystore attestation. The review feedback points out a syntax error due to an ellipsis placeholder and suggests corrections for typos and grammatical issues in the descriptions.

Comment thread identity/credentialmanager/src/main/jsonSnippets.json Outdated
Comment thread identity/credentialmanager/src/main/jsonSnippets.json Outdated
Comment thread identity/credentialmanager/src/main/jsonSnippets.json Outdated
cy245 and others added 3 commits April 23, 2026 17:39
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Copy link
Copy Markdown
Contributor

@kkuan2011 kkuan2011 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but would be good to get an identity teammate to review too :)

@cy245
Copy link
Copy Markdown
Contributor Author

cy245 commented Apr 23, 2026

Looks good, but would be good to get an identity teammate to review too :)

Already approved in the CL, just transcribing here

@cy245 cy245 enabled auto-merge (squash) April 23, 2026 21:52
@cy245 cy245 merged commit 530e577 into main Apr 23, 2026
6 checks passed
@cy245 cy245 deleted the identity_add_issuance_attestation branch April 23, 2026 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants