Skip to content

minor update to comments and material values#898

Merged
amyZepp merged 1 commit into
mainfrom
minor_update
May 5, 2026
Merged

minor update to comments and material values#898
amyZepp merged 1 commit into
mainfrom
minor_update

Conversation

@amyZepp
Copy link
Copy Markdown
Contributor

@amyZepp amyZepp commented May 5, 2026

No description provided.

@amyZepp amyZepp requested a review from a team as a code owner May 5, 2026 02:35
@amyZepp amyZepp enabled auto-merge (squash) May 5, 2026 02:35
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the GLB model path and adjusts material color factors in SpatialGltfModel.kt and MaterialOverride.kt, while also removing a redundant comment. Feedback was provided to use the more idiomatic and robust Kotlin Path function for model loading instead of Paths.get.

@android android deleted a comment from gemini-code-assist Bot May 5, 2026
Copy link
Copy Markdown
Contributor

@vad710 vad710 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@amyZepp amyZepp merged commit 6b05a55 into main May 5, 2026
6 checks passed
@amyZepp amyZepp deleted the minor_update branch May 5, 2026 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants