Update the device availability snippets#908
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the collectDeviceLifecycle function to reactively monitor projected device connection states using flatMapLatest and isProjectedDeviceConnected. The changes include adding necessary API requirements and experimental annotations. Feedback focuses on improving the formatting of the @OptIn annotation and ensuring that CancellationException is not swallowed in the try-catch block, which is critical for proper coroutine cancellation behavior.
| } catch (e: Exception) { | ||
| flowOf(Lifecycle.State.DESTROYED) | ||
| } |
There was a problem hiding this comment.
Catching a broad Exception can inadvertently intercept CancellationException, which is essential for the proper functioning of Kotlin coroutines (e.g., when flatMapLatest cancels the previous block). It is recommended to explicitly rethrow CancellationException to maintain proper structured concurrency behavior. Additionally, if you know the specific exceptions thrown by the API (such as IllegalStateException), it is better to catch those specifically.
| } catch (e: Exception) { | |
| flowOf(Lifecycle.State.DESTROYED) | |
| } | |
| } catch (e: Exception) { | |
| if (e is kotlinx.coroutines.CancellationException) throw e | |
| flowOf(Lifecycle.State.DESTROYED) | |
| } |
There was a problem hiding this comment.
Done! catching an IllegalStateException now.
devbridie
force-pushed
the
tb/device_availability_update
branch
from
253d43e to
6af51be
Compare
2 participants
Update the device availability snippets to check for projected device connection first before getting the lifecycle.