Skip to content
This repository was archived by the owner on Aug 29, 2025. It is now read-only.

Add download image from internet demo#82

Merged
yrezgui merged 32 commits intomainfrom
add-photo-from-internet-demo
Apr 22, 2021
Merged

Add download image from internet demo#82
yrezgui merged 32 commits intomainfrom
add-photo-from-internet-demo

Conversation

@yrezgui
Copy link
Copy Markdown
Contributor

@yrezgui yrezgui commented Mar 22, 2021

No description provided.

@yrezgui yrezgui requested a review from nic0lette March 22, 2021 13:05
nic0lette
nic0lette approved these changes Mar 22, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@nic0lette nic0lette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm -- in general just adding comments to expand upon methods/callbacks would be helpful for newer devs, I think.

Comment thread ScopedStorage/app/src/main/java/com/samples/storage/mediastore/AddMediaViewModel.kt Outdated
Comment thread ScopedStorage/app/src/main/java/com/samples/storage/mediastore/AddMediaViewModel.kt
Comment thread ScopedStorage/app/src/main/java/com/samples/storage/mediastore/AddMediaViewModel.kt
cketti
cketti reviewed Mar 22, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@cketti cketti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the process is killed while the camera is active (not an uncommon occurrence on certain devices) the value of temporaryMediaUri is lost (simulate with "Don't keep activities"). The value should be persisted using the saved state mechanism.

Comment thread ScopedStorage/app/src/main/java/com/samples/storage/mediastore/AddMediaViewModel.kt Outdated
Comment thread ScopedStorage/app/src/main/java/com/samples/storage/mediastore/AddMediaViewModel.kt Outdated
Comment thread ScopedStorage/app/src/main/java/com/samples/storage/mediastore/AddMediaViewModel.kt Outdated
Comment thread ScopedStorage/app/src/main/java/com/samples/storage/mediastore/AddMediaViewModel.kt Outdated
Comment thread ScopedStorage/app/src/main/java/com/samples/storage/mediastore/AddMediaViewModel.kt Outdated
@yrezgui @cketti
Apply suggestions from code review
84fdda0 
Co-authored-by: cketti <ck@cketti.de>
@google-cla
Copy link
Copy Markdown

google-cla Bot commented Mar 26, 2021

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@cketti
Copy link
Copy Markdown
Contributor

cketti commented Mar 28, 2021

I signed the CLA. But the system doesn't let me add ck@cketti.de as alternate email address.

If you want to keep the Co-authored-by line you should probably change the address to cketti@gmail.com to make the bot happy. I'm also fine with removing the Co-authored-by.

dependabot Bot and others added 21 commits April 1, 2021 05:47
@dependabot
Bump com.diffplug.spotless from 5.11.0 to 5.11.1 in /ScopedStorage
eca6f6e 
Bumps com.diffplug.spotless from 5.11.0 to 5.11.1.

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot
Bump activity-ktx from 1.3.0-alpha04 to 1.3.0-alpha05 in /ScopedStorage
a6c6e05 
Bumps activity-ktx from 1.3.0-alpha04 to 1.3.0-alpha05.

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot
Bump lifecycle-livedata-ktx from 2.3.0 to 2.3.1 in /ScopedStorage
b0d074a 
Bumps lifecycle-livedata-ktx from 2.3.0 to 2.3.1.

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot
Bump kotlin_version from 1.4.31 to 1.4.32 in /ScopedStorage
a28a37a 
Bumps `kotlin_version` from 1.4.31 to 1.4.32.

Updates `kotlin-gradle-plugin` from 1.4.31 to 1.4.32
- [Release notes](https://github.com/JetBrains/kotlin/releases)
- [Changelog](https://github.com/JetBrains/kotlin/blob/v1.4.32/ChangeLog.md)
- [Commits](JetBrains/kotlin@v1.4.31...v1.4.32)

Updates `kotlin-stdlib` from 1.4.31 to 1.4.32
- [Release notes](https://github.com/JetBrains/kotlin/releases)
- [Changelog](https://github.com/JetBrains/kotlin/blob/v1.4.32/ChangeLog.md)
- [Commits](JetBrains/kotlin@v1.4.31...v1.4.32)

Signed-off-by: dependabot[bot] <support@github.com>
@yrezgui
Merge pull request #87 from android/a4c3dependabot/gradle/ScopedStora…
20a31a8 
…ge/kotlin_version-1.4.32

Bump kotlin_version from 1.4.31 to 1.4.32 in /ScopedStorage
@yrezgui
Merge pull request #86 from android/e8e9dependabot/gradle/ScopedStora…
3906b5f 
…ge/androidx.lifecycle-lifecycle-livedata-ktx-2.3.1

Bump lifecycle-livedata-ktx from 2.3.0 to 2.3.1 in /ScopedStorage
@yrezgui
Merge pull request #83 from android/e380dependabot/gradle/ScopedStora…
efa7caa 
…ge/com.diffplug.spotless-5.11.1

Bump com.diffplug.spotless from 5.11.0 to 5.11.1 in /ScopedStorage
@yrezgui
Merge pull request #85 from android/4031dependabot/gradle/ScopedStora…
4a76a7f 
…ge/androidx.activity-activity-ktx-1.3.0-alpha05

Bump activity-ktx from 1.3.0-alpha04 to 1.3.0-alpha05 in /ScopedStorage
@dependabot
Bump lifecycle-viewmodel-ktx from 2.3.0 to 2.3.1 in /ScopedStorage
1e4a370 
Bumps lifecycle-viewmodel-ktx from 2.3.0 to 2.3.1.

Signed-off-by: dependabot[bot] <support@github.com>
@yrezgui
Merge pull request #84 from android/c824dependabot/gradle/ScopedStora…
c239107 
…ge/androidx.lifecycle-lifecycle-viewmodel-ktx-2.3.1

Bump lifecycle-viewmodel-ktx from 2.3.0 to 2.3.1 in /ScopedStorage
use viewLifecycleOwner
19aee7f
use supportFragmentManager#commit
8347972
delete unused import
1a2da86
Fix Duplicate setContentView
b82e856
@yrezgui
Merge pull request #94 from LeoAndo/duplicate_setContentView
c73f744 
Fix Duplicate setContentView
@yrezgui
Merge pull request #92 from LeoAndo/use_support_fragment_manager_commit
f135cda 
use supportFragmentManager#commit
@yrezgui
Merge pull request #91 from LeoAndo/use_viewLifecycleOwner
550468a 
use viewLifecycleOwner
@yrezgui
Upgrade dependencies
d047f6e
@yrezgui
Add more comments
452b9d0
@yrezgui
Add comments
ce79599
@yrezgui
Add savedStateHandle logic to avoid losing viewmodel data if process …
43ed00f 
…is killed

Add more comments
@google-cla
Copy link
Copy Markdown

google-cla Bot commented Apr 19, 2021

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@google-cla
Copy link
Copy Markdown

google-cla Bot commented Apr 19, 2021

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@yrezgui
Fix TakeVideo intent interaction
9be8c46 
Add custom TakeVideo activityResult contract
Remove unused code
Replace Coil by Glide (issues with generating thumbnails for video)
@google-cla
Copy link
Copy Markdown

google-cla Bot commented Apr 20, 2021

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@yrezgui yrezgui added the cla: yes If CLA assistant can't fix the PR check label Apr 21, 2021
@google-cla
Copy link
Copy Markdown

google-cla Bot commented Apr 22, 2021

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@google-cla google-cla Bot added cla: no and removed cla: yes If CLA assistant can't fix the PR check labels Apr 22, 2021
@yrezgui yrezgui added cla: yes If CLA assistant can't fix the PR check and removed cla: no labels Apr 22, 2021
@yrezgui yrezgui merged commit 940f959 into main Apr 22, 2021
@yrezgui yrezgui deleted the add-photo-from-internet-demo branch April 22, 2021 14:42
@243573077 243573077 mentioned this pull request Jun 23, 2021
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@cketti cketti cketti left review comments

@nic0lette nic0lette nic0lette approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes If CLA assistant can't fix the PR check

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@yrezgui @cketti @nic0lette