This repository was archived by the owner on Jan 9, 2026. It is now read-only.
Fix remove playing notification when app is swiped from recents#273
Merged
Merged
Conversation
Contributor
|
Thank you very much for the PR! It'll probably take a bit of time for me to merge it, but I just wanted to let you know I saw it and it's on my list of things to do! |
nic0lette
added a commit
that referenced
this pull request
May 7, 2019
Merge branch 'fix-remove-notification' of https://github.com/YuriPopiv/android-UniversalMusicPlayer into YuriPopiv-fix-remove-notification Change-Id: I504941efe37c349f7739aaae4eb6a4e523a474aa
nic0lette
added a commit
that referenced
this pull request
May 7, 2019
GitHub PR #273 Change-Id: Ifd5c1639e43d0a8842ad306a95d34c3441c2b4af
Contributor
|
Thanks again! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix GitHub issue #250
When I swipe UAMP away from recents, the
removeNowPlayingNotification()isn't called because in the methodupdateNotification()the metadata is alreadynulland this check returns without removing notificationif(mediaController.metadata == null) return. So because of this notification is stuck in the notification tray and control icons also does not work.