This repository was archived by the owner on Jan 9, 2026. It is now read-only.
Fix: keep isForegroundService flag in sync with service state#445
Merged
nic0lette merged 1 commit intoApr 8, 2021
Conversation
…from the foreground because of playback state change
nic0lette
approved these changes
Apr 8, 2021
Contributor
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This closes #444.
The local flag
isForegroundServiceis currently only set tofalsewhen the notification is cancelled:uamp/common/src/main/java/com/example/android/uamp/media/MusicService.kt
Lines 592 to 596 in 8dda0e8
There is however another scenario that will stop the service from running in the foreground: when the player's playback state changes to paused (
playWhenReady == false)uamp/common/src/main/java/com/example/android/uamp/media/MusicService.kt
Lines 615 to 621 in 8dda0e8
In this last scenario,
isForegroundServiceis not set tofalse, which prevents it from being promoted to the foreground again when a notification update is posted:uamp/common/src/main/java/com/example/android/uamp/media/MusicService.kt
Lines 581 to 590 in 8dda0e8
This PR adds that missing statement, allowing the service to be promoted to the foreground again when playback resumes.
For a more extensive description of the bug, see issue description.