Update VkQuality to 1.2.4 release.#13
Conversation
Changes final-check behavior on unknown devices to recommend Vulkan if the device declares passing on dEQP 2024.03.01 or later. Replaces the 'future Android' recommendation for fail-forward.
There was a problem hiding this comment.
Code Review
This pull request updates the Vulkan Quality library to version 1.2.4, introducing Vulkan dEQP level detection to recommend Vulkan on unknown devices, deprecating future Android Vulkan criteria, and skipping fingerprint checks by default. It also fixes a sequential wildcard matching logic flaw, adds robust validation against integer overflows in prediction files, and updates device lists with Pixel 9a and Pixel 10 series devices. The review feedback highlights two important issues: first, a critical JNI exception handling flaw in GetVulkanDEQPLevel that could lead to VM crashes if Java exceptions are not cleared inside the loop; second, a potential format string truncation issue in ValidateFile where size_t is cast to int instead of using the %zu format specifier.
VkQuality 1.2.4 changes: