Skip to content

fix(featured-compose): update API dump after FakeConfigValues removal #148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kirich1409 merged 1 commit into from
Apr 3, 2026
+0 −10
Merged

fix(featured-compose): update API dump after FakeConfigValues removal #148

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 0 additions & 10 deletions featured-compose/api/jvm/featured-compose.api
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,16 +2,6 @@ public final class dev/androidbroadcast/featured/compose/ConfigValuesComposeExte
public static final fun collectAsState (Ldev/androidbroadcast/featured/ConfigValues;Ldev/androidbroadcast/featured/ConfigParam;Landroidx/compose/runtime/Composer;I)Landroidx/compose/runtime/State;
}

public final class dev/androidbroadcast/featured/compose/FakeConfigValuesKt {
Copy link
Copy Markdown

@qodo-code-review qodo-code-review bot Apr 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Action required

1. Android api dump stale 🐞 Bug ≡ Correctness

This PR updates only the JVM API dump, but the Android API dump still declares
FakeConfigValuesKt/FakeConfigValuesScope as public even though the source marks them internal, so
android apiCheck will continue to fail. Update/regenerate the Android dump to match the current
public API surface.
Agent Prompt 
### Issue description
The Android BCV API dump for `featured-compose` is stale: it still exposes `FakeConfigValuesKt`/`FakeConfigValuesScope` even though these APIs are `internal` in source and were removed from the JVM dump in this PR.

### Issue Context
`featured-compose` applies the BCV plugin and maintains separate dumps under `featured-compose/api/android` and `featured-compose/api/jvm`. The JVM dump was updated, but the Android dump still contains the removed symbols.

### Fix Focus Areas
- featured-compose/api/android/featured-compose.api[1-18]
- featured-compose/src/commonMain/kotlin/dev/androidbroadcast/featured/compose/FakeConfigValues.kt[16-54]
- featured-compose/api/jvm/featured-compose.api[1-8]

### What to do
Regenerate or edit `featured-compose/api/android/featured-compose.api` so it no longer contains `FakeConfigValuesKt` and `FakeConfigValuesScope` (matching the current visibility in source and the updated JVM dump).

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools

public static final fun fakeConfigValues (Lkotlin/jvm/functions/Function1;)Ldev/androidbroadcast/featured/ConfigValues;
public static synthetic fun fakeConfigValues$default (Lkotlin/jvm/functions/Function1;ILjava/lang/Object;)Ldev/androidbroadcast/featured/ConfigValues;
}

public final class dev/androidbroadcast/featured/compose/FakeConfigValuesScope {
public static final field $stable I
public final fun set (Ldev/androidbroadcast/featured/ConfigParam;Ljava/lang/Object;)V
}

public final class dev/androidbroadcast/featured/compose/LocalConfigValuesKt {
public static final fun getLocalConfigValues ()Landroidx/compose/runtime/ProvidableCompositionLocal;
}
Comment on lines 4 to 7
Copy link

Copilot AI Apr 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This updates the JVM API dump to remove FakeConfigValues*, but featured-compose/api/android/featured-compose.api still contains FakeConfigValuesKt / FakeConfigValuesScope. If those APIs were removed/hidden, the Android API dump likely also needs regeneration; otherwise apiCheck will continue to fail due to the stale Android dump.

Copilot uses AI. Check for mistakes.
Expand Down
Loading