Move Gradle plugin from build-logic/ to repo root#215
Merged
Conversation
build-logic/ is the conventional location for internal convention plugins, not a published Maven Central artifact. Moves the plugin to its own included build at featured-gradle-plugin/ (the previously empty directory), matching the standard OSS Gradle plugin layout. Dogfooding on :sample:feature-* remains via includeBuild(...) — no functional change. Removes the empty build-logic/ wrapper. Updates root settings.gradle.kts, build.gradle.kts and CLAUDE.md to reflect the new structure.
Qodo reviews are paused for this user.Troubleshooting steps vary by plan Learn more → On a Teams plan? Using GitHub Enterprise Server, GitLab Self-Managed, or Bitbucket Data Center? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
dev.androidbroadcast.featured) lived inbuild-logic/featured-gradle-plugin/while a stale emptyfeatured-gradle-plugin/directory sat at the repo root — confusing layout from a partial earlier refactor.build-logic/is the conventional location for internal convention plugins, not for a Maven-Central artifact. Standard OSS Gradle-plugin repos (Detekt, OkHttp, Ktlint, …) keep the published plugin in its own directory and reservebuild-logic/for build-internal logic.featured-gradle-plugin/as an included build at the repo root and removes the now-redundantbuild-logic/wrapper.What changed
git mvof all 78 plugin sources/tests/fixtures frombuild-logic/featured-gradle-plugin/tofeatured-gradle-plugin/.build-logic/settings.gradle.ktsintofeatured-gradle-plugin/settings.gradle.kts(now a standalone included-build root:rootProject.name = "featured-gradle-plugin", no nestedinclude(...)).settings.gradle.kts:includeBuild("build-logic")→includeBuild("featured-gradle-plugin").build.gradle.kts:gradle.includedBuild("build-logic").task(":featured-gradle-plugin:publishTo…")→gradle.includedBuild("featured-gradle-plugin").task(":publishTo…")for bothpublishToMavenCentralandpublishToMavenLocal.build-logic/.CLAUDE.mdto reflect the new layout (and to actually document architecture/commands — prior content was minimal).No functional change: the plugin is still consumed via
includeBuild(...)for dogfooding on:sample:feature-*, the publication coordinates are unchanged, and no production sources were touched.Test plan
./gradlew :featured-gradle-plugin:compileKotlin— green./gradlew :featured-gradle-plugin:test— 266 tests green./gradlew :core:assemble,:sample:android-app:assemble(and other key modules) — green./gradlew spotlessCheck— green🤖 Generated with Claude Code