setProgress(position, velocity) always sets position to 1

[PaulKlauser]

Issue

Calling setProgress(position: Float, velocity: Float) always results in the layout's progress being set to 1. Looks like this is caused by always calling setPosition(1f) here:

constraintlayout/constraintlayout/constraintlayout/src/main/java/androidx/constraintlayout/motion/widget/MotionLayout.java

Line 1593 in df23aa8

animateTo(1);

It's not clear to me why that would be called with a value of 1f every time. If a PR removing that line would be helpful, I'm happy to do it, but it's not clear to me why that was added in the first place, the git history seems to be lost from the migration to GitHub.

Workaround

My workaround for now is to override that method locally and just call the setProgress(position: Float) overload instead, as that doesn't exhibit this behavior. Granted velocity is now being lost on that call.

Examples

MotionLayoutProgress.zip

motion_layout_progress_bug.mp4

[PaulKlauser]

This issue is also the cause of the behavior described in: https://issuetracker.google.com/issues/199754674

[jafu888]

It is a bug.
The use case of calling this API velocity was assumed to be > 0.
it will probably be changed to if (v!=0.0f) anaimateTo(0>1?1:0);

[PaulKlauser]

This appears to be fixed by @jafu888 's commit mentioned above, which is released in v2.1.2. Closing.