This repository was archived by the owner on Dec 27, 2024. It is now read-only.
[ComposeMotion] Fix custom properties#640
Merged
Merged
Conversation
Custom properties would return values that didn't correspond to the layout, since they were effectively being calculated with a progress value form a different measure pass. This makes it so that custom properties are always calculated with the current progress value used to measure the layout in the current composition.
oscar-ad
force-pushed
the
customPropsRework
branch
from
1686026 to
542dd1b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Custom properties would return values that didn't correspond to the
layout, since they were effectively being calculated with a progress
value form a different measure pass.
This makes it so that custom properties are always calculated with the
current progress value used to measure the layout in the current
composition.