Skip to content

Changing API for callback#491

Merged
andrsd merged 1 commit intomainfrom
callback-refact
Mar 18, 2024
Merged

Changing API for callback#491
andrsd merged 1 commit intomainfrom
callback-refact

Conversation

@andrsd
Copy link
Copy Markdown
Owner

@andrsd andrsd commented Mar 13, 2024

No _callback suffix, only ksp_monitor, snes_monitor and ts_monitor.

No _callback suffix, only `ksp_monitor`, `snes_monitor` and `ts_monitor`.
@andrsd andrsd added the api-change PR changes API, i.e. it will break depending apps label Mar 13, 2024
@andrsd andrsd self-assigned this Mar 13, 2024
@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.11%. Comparing base (28a1f19) to head (d06e2c7).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #491   +/-   ##
=======================================
  Coverage   88.11%   88.11%           
=======================================
  Files         175      175           
  Lines       11990    11990           
=======================================
  Hits        10565    10565           
  Misses       1425     1425           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@andrsd andrsd merged commit 708a1b1 into main Mar 18, 2024
@andrsd andrsd deleted the callback-refact branch March 18, 2024 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api-change PR changes API, i.e. it will break depending apps

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant