Skip to content

TransientProblemInterface is using delegates#540

Merged
andrsd merged 7 commits intomainfrom
ts-delegates
Jun 6, 2024
Merged

TransientProblemInterface is using delegates#540
andrsd merged 7 commits intomainfrom
ts-delegates

Conversation

@andrsd
Copy link
Copy Markdown
Owner

@andrsd andrsd commented Jun 6, 2024

  • TSMonitor is now implemented as a delegate
  • TransientProblemInterface: pre/post step is is done via static function
  • TransientProblemInterface: compute_rhs is a delegate
  • TransientProblemInterface: changing some virtual into normal methods
  • TransientProblemInterface: moving compute_ifunction_local from ImplicitFENonlinearProblem
  • TransientProblemInterface: moving compute_ijacobian_local from ImplicitFENonlinearProblem
  • TransientProblemInterface: moving compute_boundary_local from ImplicitFENonlinearProblem

@andrsd andrsd added the api-change PR changes API, i.e. it will break depending apps label Jun 6, 2024
@andrsd andrsd self-assigned this Jun 6, 2024
@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 6, 2024

Codecov Report

Attention: Patch coverage is 97.41379% with 3 lines in your changes missing coverage. Please review.

Project coverage is 88.51%. Comparing base (1a92b1c) to head (4aa8314).

Files Patch % Lines
src/TransientProblemInterface.cpp 94.73% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #540      +/-   ##
==========================================
+ Coverage   88.45%   88.51%   +0.06%     
==========================================
  Files         186      187       +1     
  Lines       11013    11081      +68     
==========================================
+ Hits         9741     9808      +67     
- Misses       1272     1273       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@andrsd andrsd merged commit c81e9e5 into main Jun 6, 2024
@andrsd andrsd deleted the ts-delegates branch June 6, 2024 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api-change PR changes API, i.e. it will break depending apps

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant