Skip to content

Redoing execute on flags#901

Merged
andrsd merged 4 commits intomainfrom
execute-on-param
Oct 25, 2025
Merged

Redoing execute on flags#901
andrsd merged 4 commits intomainfrom
execute-on-param

Conversation

@andrsd
Copy link
Copy Markdown
Owner

@andrsd andrsd commented Oct 25, 2025

  • "on" parameter in Output has ExecuteOn type
  • Improving Flags
  • Redoing ExecuteOn flags
  • Removing using namespace from some header files

@andrsd andrsd added the api-change PR changes API, i.e. it will break depending apps label Oct 25, 2025
@andrsd andrsd self-assigned this Oct 25, 2025
@andrsd andrsd added the api-change PR changes API, i.e. it will break depending apps label Oct 25, 2025
@codecov
Copy link
Copy Markdown

codecov Bot commented Oct 25, 2025

Codecov Report

❌ Patch coverage is 83.87097% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 76.28%. Comparing base (0cb50e8) to head (74b74eb).
⚠️ Report is 5 commits behind head on main.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
src/ExplicitDGLinearProblem.cpp 0.00% 2 Missing ⚠️
src/Output.cpp 85.71% 2 Missing ⚠️
src/ExplicitFVLinearProblem.cpp 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #901      +/-   ##
==========================================
- Coverage   76.31%   76.28%   -0.04%     
==========================================
  Files         159      159              
  Lines       10653    10638      -15     
==========================================
- Hits         8130     8115      -15     
  Misses       2523     2523              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@andrsd andrsd marked this pull request as draft October 25, 2025 13:19
- Flags are in `ExecuteOn` type which is an `enum class`
- And the combo of `ExecuteOn` is in `ExecuteOnFlags`
- This way we can do `ExceuteOn::INITIAL | ExecuteOn::FINAL`
...to avoid `Flags` name collision with an internal PETSc type.
@andrsd andrsd marked this pull request as ready for review October 25, 2025 13:25
@andrsd andrsd merged commit 4465717 into main Oct 25, 2025
10 checks passed
@andrsd andrsd deleted the execute-on-param branch October 25, 2025 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api-change PR changes API, i.e. it will break depending apps

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant